CodeReview auto deferring - Wikitech-l - lists.wikimedia.org

List overview All Threads
Download

CodeReview auto deferring

Image.php is deprecated need to...

shell bugs handling

Ashar Voultoiz

16 Jan 2011 16 Jan '11

8:53 p.m.

Hello, I have wgCodeReviewDeferredPaths on mediawiki.org which let us automatically defers revisions based on a path. The initial list is currently: +$wgCodeReviewDeferredPaths['mediawiki'] = array( + '%^/trunk/extensions/SemanticForms%', + '%^/trunk/WikiWord%', +); The bug report was: https://bugzilla.wikimedia.org/23494 -- Ashar Voultoiz

Reply

Show replies by date

Jeroen De Dauw

16 Jan 16 Jan

9:03 p.m.

Hey, Shouldn't that be $eg instead of $wg? Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --

Reply

Ashar Voultoiz

9:35 p.m.

On 16/01/11 20:03, Jeroen De Dauw wrote:

Shouldn't that be $eg instead of $wg?

CodeReview uses global $wgCodeReviewDeferredPaths; -- Ashar Voultoiz

Reply

Jeroen De Dauw

9:40 p.m.

Hey, My point is that code review is an extension, so AFAIK should use $eg, not $wg. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --

Reply

Chad

10:58 p.m.

I wrote the feature and I've never used $eg. -Chad On Jan 16, 2011 2:41 PM, "Jeroen De Dauw" <jeroendedauw(a)gmail.com> wrote:

Hey, My point is that code review is an extension, so AFAIK should use $eg, not $wg. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply

Platonides

11:25 p.m.

Jeroen De Dauw wrote:

Hey, My point is that code review is an extension, so AFAIK should use $eg, not $wg. Cheers

[[Coding conventions]] was wrong. See r70755

Reply

K. Peachey

17 Jan 17 Jan

1:09 a.m.

Um... I thought since that email discussion took place that sementic no longer wanted their stuff deferred?

Reply

Chad

1:16 a.m.

On Sun, Jan 16, 2011 at 6:09 PM, K. Peachey <p858snake(a)yahoo.com.au> wrote:

Um... I thought since that email discussion took place that sementic no longer wanted their stuff deferred?

That's what I hear too. Then nobody reviews stuff and it ends up deferred anyway. -Chad

Reply

4842

days inactive

4842

days old

wikitech-l@lists.wikimedia.org

Manage subscription

7 comments

5 participants

tags (0)

participants (5)

Ashar Voultoiz
Chad
Jeroen De Dauw
K. Peachey
Platonides