A trivial patch (assuming it is right, of course ;) to remove some unused variables in QueryPage.php. The patch is for trunk, but it should be applicable to REL1_5.
And BTW, what's the right place (mailing list, MediaZilla, etc.) to send patches?
/L/e/k/t/u
Index: includes/QueryPage.php =================================================================== RCS file: /cvsroot/wikipedia/phase3/includes/QueryPage.php,v retrieving revision 1.68 diff -u -2 -r1.68 QueryPage.php --- includes/QueryPage.php 16 Sep 2005 15:05:07 -0000 1.68 +++ includes/QueryPage.php 21 Sep 2005 14:58:46 -0000 @@ -230,5 +230,5 @@ */ function doQuery( $offset, $limit, $shownavigation=true ) { - global $wgUser, $wgOut, $wgLang, $wgRequest, $wgContLang; + global $wgUser, $wgOut, $wgContLang; $sname = $this->getName(); @@ -236,5 +236,4 @@ $sql = $this->getSQL(); $dbr =& wfGetDB( DB_SLAVE ); - $dbw =& wfGetDB( DB_MASTER ); $querycache = $dbr->tableName( 'querycache' );
On 21/09/05, Juanma Barranquero lekktu@gmail.com wrote:
And BTW, what's the right place (mailing list, MediaZilla, etc.) to send patches?
Probably MediaZilla, though here is fine for small ones (large ones as attachments may or may not get scrubbed out for security reasons). And once you contribute a few and prove yourself reasonably trustworthy, you can apply for CVS rights and commit them direct.
wikitech-l@lists.wikimedia.org