Paweł Dembowski wrote:
by the way, the frame issue was several times discussed on irc. It seems most browsers do a total redirect. Only a couple of editors reported the framing issue. I do not know if *we* can do something on this. Ant
I get a frame both in IE and in Firefox.
Could this be because the frame-breaking code in http://fr.wikipedia.org/skins-1.5/common/wikibits.js is executed in a <head> context, rather than a <body> context?
http://www.thesitewizard.com/archive/framebreak.shtml specifically states that the frame-breaker code must be executed in the <body>, not the <head>.
-- Neil
Neil Harris wrote:
Paweł Dembowski wrote:
by the way, the frame issue was several times discussed on irc. It seems most browsers do a total redirect. Only a couple of editors reported the framing issue. I do not know if *we* can do something on this. Ant
I get a frame both in IE and in Firefox.
Could this be because the frame-breaking code in http://fr.wikipedia.org/skins-1.5/common/wikibits.js is executed in a
<head> context, rather than a <body> context?
http://www.thesitewizard.com/archive/framebreak.shtml specifically states that the frame-breaker code must be executed in the <body>, not the <head>.
-- Neil
Working with some small test pages stripped down from the source code seems to disprove the above guesswork, as putting the script in <head> seems to work fine. However, using Firefox's Javascript console, and visiting wikipedia.fr, I get the following error:
Error: uncaught exception: Permission denied to call method Location.toString
However, visiting http://fr.wikipedia.org/wiki/Accueil does not.
Writing a genuine exception into the Javascript code certainly does torpedo the frame-breaking effect, as expected. However, the Javascript console does not give a source code line for the error, so it is presumably a low-level internal exception that is being caught, as part of something else.
Could this possibly be because of the broken HTML syntax of the wikipedia.fr frame-trapper page, which does not terminate its <head>, and has no <body> element at all?
-- Neil
Neil Harris wrote:
Neil Harris wrote:
Paweł Dembowski wrote:
by the way, the frame issue was several times discussed on irc. It seems most browsers do a total redirect. Only a couple of editors reported the framing issue. I do not know if *we* can do something on this. Ant
I get a frame both in IE and in Firefox.
Could this be because the frame-breaking code in http://fr.wikipedia.org/skins-1.5/common/wikibits.js is executed in a
<head> context, rather than a <body> context?
http://www.thesitewizard.com/archive/framebreak.shtml specifically states that the frame-breaker code must be executed in the <body>, not the <head>.
-- Neil
Working with some small test pages stripped down from the source code seems to disprove the above guesswork, as putting the script in <head> seems to work fine. However, using Firefox's Javascript console, and visiting wikipedia.fr, I get the following error:
Error: uncaught exception: Permission denied to call method Location.toString
However, visiting http://fr.wikipedia.org/wiki/Accueil does not.
Writing a genuine exception into the Javascript code certainly does torpedo the frame-breaking effect, as expected. However, the Javascript console does not give a source code line for the error, so it is presumably a low-level internal exception that is being caught, as part of something else.
Could this possibly be because of the broken HTML syntax of the wikipedia.fr frame-trapper page, which does not terminate its <head>, and has no <body> element at all?
-- Neil
The answer to my own question appears to be "no", based on playing with reduced test cases (see attached file). However, I'm now pretty convinced that the uncaught Javascript exception is the most likely cause of the failure to break out of the enclosing frame.
-- Neil
Hello,
Neil Harris neil@tonal.clara.co.uk schrieb am Sat, 03 Sep 2005 15:31:59 +0200:
Working with some small test pages stripped down from the source code seems to disprove the above guesswork, as putting the script in <head> seems to work fine. However, using Firefox's Javascript console, and visiting wikipedia.fr, I get the following error:
Error: uncaught exception: Permission denied to call methodLocation.toString
However, visiting http://fr.wikipedia.org/wiki/Accueil does not.
wikibits.js has an exeption to this for http://www.flacus.de/wikipedia/Interwiki-Link-Checker/wiki.php, which is a very good tool. The JavaScript code for this is:
if (window.top.location != 'http://www.flacus.de/wikipedia/Interwiki-Link-Checker/wiki.php') { window.top.location = window.location; }
But it is NOT possible to access "window.top.location" if window.top is on another domain/server - thats why firefox says, that the permission of getting "location" was refused. Opera says "message: Security error: attempted to read protected variable".
It doesn't work on firefox, opera 8 and IE6/7.
Sorry, but I don't have a solution for that.
Christian Thiele
wikitech-l@lists.wikimedia.org