Gerrit 2.6 - coming to a server near you - Wikitech-l

List overview All Threads
Download

newer

Gerrit 2.6 - coming to a server near you

older

Belated welcome to Christian...

Announcement: Ed Sanders joins...

Chad

4 Feb 2013 4 Feb '13

7:44 p.m.

Hi, After much delay, Gerrit 2.6 will be coming to our servers. This release brings a *lot* of really cool features and fixes, but I'd like to outline a couple of the major ones: * A stable, documented RESTful api * Plugin support: ** We'll be replacing Gitweb with Gitblit once the initial dust of the upgrade settles ** We've got a plugin to let us delete projects ** We're working on plugins for renaming projects, as well as providing some Bugzilla integration * IE9 & IE10 are now supported * The code formatter got some updates, which should solve some of the ArrayIndexOutOfBounds errors you saw in some diffs. * Ability to leave comments on a whole file (instead of just a line in a file) * Search suggestions * More unicorns! We're planning to do this on 1:00-2:00UTC on February 12th (that's 17:00-18:00 PST on February 11th) -- that's one week from today. -Chad

Show replies by date

Mark A. Hershberger

4 Feb 4 Feb

10:19 p.m.

On 02/04/2013 06:44 AM, Chad wrote:

...

** We'll be replacing Gitweb with Gitblit once the initial dust of the upgrade settles

Does this mean new links will be in place? I've used links like https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=f04… and it would be nice if those didn't break. -- http://hexmode.com/ There is no path to peace. Peace is the path. -- Mahatma Gandhi, "Non-Violence in Peace and War"

Chad

10:29 p.m.

On Mon, Feb 4, 2013 at 9:19 AM, Mark A. Hershberger <mah(a)everybody.org> wrote:

...

On 02/04/2013 06:44 AM, Chad wrote:

** We'll be replacing Gitweb with Gitblit once the initial dust of the upgrade settles

Does this mean new links will be in place? I've used links like https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=f04… and it would be nice if those didn't break.

Yes, the urls will be changing. If we can come up with some sane rewrite rules, I think we could redirect gitweb urls to gitblit. -Chad

Sébastien Santoro

11:21 p.m.

On Mon, Feb 4, 2013 at 3:29 PM, Chad <innocentkiller(a)gmail.com> wrote:

...

Does this mean new links will be in place? I've used links like https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=f04… and it would be nice if those didn't break.

Yes, the urls will be changing. If we can come up with some sane rewrite rules, I think we could redirect gitweb urls to gitblit.

For nginx or Apache? -- Sébastien Santoro aka Dereckson http://www.dereckson.be/

Chad

5 Feb 5 Feb

12:31 a.m.

On Mon, Feb 4, 2013 at 10:21 AM, Sébastien Santoro <dereckson(a)espace-win.org> wrote:

...

On Mon, Feb 4, 2013 at 3:29 PM, Chad <innocentkiller(a)gmail.com> wrote:

Does this mean new links will be in place? I've used links like https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=commit;h=f04… and it would be nice if those didn't break.

Yes, the urls will be changing. If we can come up with some sane rewrite rules, I think we could redirect gitweb urls to gitblit.

For nginx or Apache?

Apache. The configuration of Gerrit can be found in the puppet repo, in templates/apache/gerrit.wikimedia.org.erb. -Chad

Matthew Walker

2:25 a.m.

...

If we can come up with some sane rewrite rules, I think we could redirect gitweb urls to gitblit.

+1 -- like Mark I've used gitweb URLs in several places that I wouldn't like to see breaking (one of them is original source of images moved to commons from git). ~Walker

Chad

6:43 a.m.

On Mon, Feb 4, 2013 at 6:44 AM, Chad <innocentkiller(a)gmail.com> wrote:

...

I can't believe I forgot to mention two of my favorite new features: * Editing topics and commit messages directly from the UI :) -Chad

Chad

8 Feb 8 Feb

9:52 p.m.

On Mon, Feb 4, 2013 at 6:44 AM, Chad <innocentkiller(a)gmail.com> wrote:

...

Hi, After much delay, Gerrit 2.6 will be coming to our servers. This release brings a *lot* of really cool features and fixes, but I'd like to outline a couple of the major ones:

I realized a little bit ago that I was a bit ambitious in calling the deployment 2.6, so please let me clarify. Gerrit doesn't name their master 2.6alpha like we do 1.21alpha, which was the source of my confusion. We're actually going to use 2.5.1-1225-gd52acbc, which is based on Wednesday's nightly build of d52acbc from master. This is effectively what will become 2.6 upstream when they finally release ;-) Just wanted to be explicit about which version we're deploying, since I got some questions on IRC a bit ago about 2.5 vs. 2.6. Rest assured--we will still be getting the latest and greatest. And we're still on target for late Monday/early Tuesday. -Chad

Chad

12 Feb 12 Feb

7:49 a.m.

On Fri, Feb 8, 2013 at 8:52 AM, Chad <innocentkiller(a)gmail.com> wrote:

...

Rest assured--we will still be getting the latest and greatest. And we're still on target for late Monday/early Tuesday.

Friendly reminder that Gerrit will be coming down in about an hour for the upgrade. During the upgrade, you may be able to hit Gerrit intermittently as it'll restart several times. Once the dust has settled, I'll be sure to let everyone know. -Chad

Chad

10:33 a.m.

On Mon, Feb 11, 2013 at 6:49 PM, Chad <innocentkiller(a)gmail.com> wrote:

...

On Fri, Feb 8, 2013 at 8:52 AM, Chad <innocentkiller(a)gmail.com> wrote:

Rest assured--we will still be getting the latest and greatest. And we're still on target for late Monday/early Tuesday.

Took a few minutes longer than expected, but we're back up and everything's live. We had to deploy a newer version to grab one last fix we spotted during the upgrade. Our deployed version is now 2.5.1-1266-gcc231e1. There might be a few problems left over with the IRC notifications, I'll tackle those tomorrow (making sure replication is working properly now). If you spot any other problems, please let me know. -Chad

Ori Livneh

12:34 p.m.

On Monday, February 11, 2013 at 6:33 PM, Chad wrote:

...

Cool, well done. The UI has become more polished, it seems, and considerably more responsive. It feels a lot faster than before. LGTM! -- Ori Livneh

Matthew Flaschen

12:57 p.m.

On 02/11/2013 09:33 PM, Chad wrote:

...

There might be a few problems left over with the IRC notifications, I'll tackle those tomorrow (making sure replication is working properly now). If you spot any other problems, please let me know.

I'm getting Internal Server Error intermittently in the add a reviewer box. Matt Flaschen

Chad

12:59 p.m.

On Mon, Feb 11, 2013 at 11:57 PM, Matthew Flaschen <mflaschen(a)wikimedia.org> wrote:

...

On 02/11/2013 09:33 PM, Chad wrote:

There might be a few problems left over with the IRC notifications, I'll tackle those tomorrow (making sure replication is working properly now). If you spot any other problems, please let me know.

I'm getting Internal Server Error intermittently in the add a reviewer box.

Roan was hitting this earlier, but I wasn't able to replicate at the time. It's on my todo list to check tomorrow morning. -Chad

Matthew Walker

13 Feb 13 Feb

2:45 a.m.

I am liking the new UI features. However -- I notice that I seem to have lost +2 rights to mediawiki/core. Are we rolling back the policy that all foundation developers have +2? ~Matt Walker On Mon, Feb 11, 2013 at 6:33 PM, Chad <innocentkiller(a)gmail.com> wrote:

...

On Mon, Feb 11, 2013 at 6:49 PM, Chad <innocentkiller(a)gmail.com> wrote:

On Fri, Feb 8, 2013 at 8:52 AM, Chad <innocentkiller(a)gmail.com> wrote: > Rest assured--we will still be getting the latest and greatest. And

we're still

on target for late Monday/early Tuesday.

Chad

2:50 a.m.

On Tue, Feb 12, 2013 at 1:45 PM, Matthew Walker <mwalker(a)wikimedia.org> wrote:

...

I am liking the new UI features. However -- I notice that I seem to have lost +2 rights to mediawiki/core. Are we rolling back the policy that all foundation developers have +2?

No, this should not have changed... -Chad

Bartosz Dziewoński

2:54 a.m.

Are you logged in? Everyone got logged out apparently, and this bit me at first, too. -- Matma Rex

Matthew Walker

3:22 a.m.

Yep. Logged in as mwalker(a)wikimedia.org. It's odd because I still have +2 on the fundraising repos. Maybe the ACL computation changed and I'm not in some group that I should have been in? ~Matt Walker On Tue, Feb 12, 2013 at 10:54 AM, Bartosz Dziewoński <matma.rex(a)gmail.com>wrote;wrote:

...

Are you logged in? Everyone got logged out apparently, and this bit me at first, too. -- Matma Rex ______________________________**_________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-l<https://lists.…

Merlijn van Deen

5:18 a.m.

Hi Chad, On 12 February 2013 03:33, Chad <innocentkiller(a)gmail.com> wrote:

...

Thanks for performing the upgrade! I'm not sure if anything but the reviewer bot (and the UI) uses the API, but it has been *moved* from https://gerrit.wikimedia.org/r/gerrit/rpc/ChangeDetailService to https://gerrit.wikimedia.org/r/gerrit_ui/rpc/ChangeDetailService . It will return an Internal Server Error when the original URL is accessed (with POST data, from the browser it's 404). This might be related to the errors seen by Matt and Roan: old javascript code trying to access the old URL. Merlijn

Chad

5:29 a.m.

On Tue, Feb 12, 2013 at 4:18 PM, Merlijn van Deen <valhallasw(a)arctus.nl> wrote:

...

Hi Chad, On 12 February 2013 03:33, Chad <innocentkiller(a)gmail.com> wrote:

As we just discussed on IRC, the JSON-RPC interface has largely been removed and replaced by the RESTful APIs which are meant for public consumption and are going to be much more stable. For anyone who's interested in developing things against the API, there are docs: https://gerrit.wikimedia.org/r/Documentation/rest-api.html The problem Roan and others were having with adding reviewers was unrelated, and should be fixed now. -Chad

Tyler Romeo

5:29 a.m.

Some other new features I've noticed that haven't been listed: * Showing who has the ability to vote in each category (easily identify project owners). * Switch patchsets while in diff view. * Changes show if they need to be rebased. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo(a)gmail.com On Tue, Feb 12, 2013 at 4:18 PM, Merlijn van Deen <valhallasw(a)arctus.nl>wrote;wrote:

...

Hi Chad, On 12 February 2013 03:33, Chad <innocentkiller(a)gmail.com> wrote:

4090

days inactive

4098

days old

wikitech-l@lists.wikimedia.org

Manage subscription

19 comments

9 participants

tags (0)

participants (9)

Bartosz Dziewoński
Chad
Mark A. Hershberger
Matthew Flaschen
Matthew Walker
Merlijn van Deen
Ori Livneh
Sébastien Santoro
Tyler Romeo