Hey, Daniel, thanks for your suggestion. Going on the little documentation, "Name/value pairs to be cached in the DB", it seems that everything added via setProperty goes into the parser cache. There is no point in this data going in there, so using setProperty does not seem ideal. Anything more suited already there? Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --

Hi Daniel, hi Jeroen, hi all, On 20/10/12 16:47, Daniel Friesen wrote: ... The data is used during and right after parsing, when the article is saved. The task here is to allow hooks to collect information during parsing and to process this information afterwards. The purpose of the change is to pass information sideways from one hook to the next. It would not be useful to store any of this information in the MW DB or in any cache. Markus

P.S.: I have now seen that the discussion on gerrit is actually already a lot further than in this thread. Looks like we have a feasible conclusion there already. https://gerrit.wikimedia.org/r/28767 On 20/10/12 17:15, Markus Krötzsch wrote: > Hi Daniel, hi Jeroen, hi all, > > On 20/10/12 16:47, Daniel Friesen wrote: >> On Sat, 20 Oct 2012 06:14:36 -0700, Jeroen De Dauw >> <jeroendedauw(a)gmail.com> wrote: >> >>> Hey, >>> >>> Daniel, thanks for your suggestion. >>> >>> Going on the little documentation, "Name/value pairs to be cached in >>> the >>> DB", it seems that everything added via setProperty goes into the >>> parser >>> cache. There is no point in this data going in there, so using >>> setProperty >>> does not seem ideal. Anything more suited already there? >>> >>> Cheers >>> > ... >> Wait, I can understand wanting data that goes into the cached parser >> output but is not saved into page_props. >> >> But are you saying that this SMW isn't actually used at all after >> parsing is finished, only during? > > The data is used during and right after parsing, when the article is > saved. The task here is to allow hooks to collect information during > parsing and to process this information afterwards. The purpose of the > change is to pass information sideways from one hook to the next. It > would not be useful to store any of this information in the MW DB or in > any cache. > > Markus

Then unset it at the point when you collect it, just before it is saved.

Also note that ParserOutput already stores much more than it strictly needs, so adding one more item won't harm.