I wasn't sure about Evan's new colour scheme -- I think people would be confused by broken links that look like stubs and stubs that look like visited links. So I committed the new style sheets in an "alternate" directory. That also required a minor change to the installer.
Setting the default style for <a> tags caused all headings to turn bright blue, on pages with TOCs. So I commented that line out.
While I was at it, I noticed that ordinary internal links were underlined regardless of the user preferences. Brion took out the class=internal from ordinary links a while ago, putting it back in seemed to fix the problem.
The only other change I made to Evan's stuff was adding the ability to disable the cookie check in LocalSettings.php
-- Tim Starling.
On Nov 22, 2003, at 05:58, Tim Starling wrote:
While I was at it, I noticed that ordinary internal links were underlined regardless of the user preferences. Brion took out the class=internal from ordinary links a while ago, putting it back in seemed to fix the problem.
The internal was removed deliberately to cut bandwidth usage. ;) The style definition needs to be changed to remove the underline when non-underlined links are set (and to do *nothing*, leaving browser default, when the default is set).
-- brion vibber (brion @ pobox.com)
"TS" == Tim Starling ts4294967296@hotmail.com writes:
TS> I wasn't sure about Evan's new colour scheme -- I think people TS> would be confused by broken links that look like stubs and TS> stubs that look like visited links.
Hmm. The whole point was to get rid of that! The original bug was that stubs and visited links looked exactly alike. Are you sure you got the stylesheets installed correctly?
The color scheme I added was the one suggested on the Cologne Blue skin problems page:
Type Unvisited Visited --------- ---------- Internal Blue Dark Blue External Green Dark Green Interwiki Green Dark Green Broken Red Dark Red Stub Purple Dark Purple
I'm looking at it right now... looks like the stylesheet I sent does that. Does the light purple really look all that much like the dark red? And the light purple looks like the dark blue? I tried to use simple colors to get the idea down for first, but let it get finetuned later.
~ESP
Evan Prodromou wrote:
Type Unvisited Visited --------- ---------- Internal Blue Dark Blue External Green Dark Green Interwiki Green Dark Green Broken Red Dark Red Stub Purple Dark PurpleI'm looking at it right now... looks like the stylesheet I sent does that. Does the light purple really look all that much like the dark red? And the light purple looks like the dark blue? I tried to use simple colors to get the idea down for first, but let it get finetuned later.
No, light purple does not look like dark red, light purple looks like light purple. I meant that your unvisited stubs look like the current internal visited links (and the browser default visited links), and that your broken visited links look like stubs do at the moment. So it would be confusing for people who are used to the current system, until they got used to it. I'm not saying there's anything wrong with your system, I'm just saying that the conversion would be jarring to regular users, and that it would likely lead to lots of complaints. It's one of those features that will have to be discussed and approved by the users before it can be implemented. Perhaps we can set up a demonstration page somewhere so that people can see whether they like it or not.
-- Tim Starling.
"TS" == Tim Starling ts4294967296@hotmail.com writes:
TS> I meant that your unvisited stubs look like the current TS> internal visited links (and the browser default visited TS> links), and that your broken visited links look like stubs do TS> at the moment. So it would be confusing for people who are TS> used to the current system, until they got used to it.
Ah! Now I understand what you're saying.
TS> I'm not saying there's anything wrong with your system, [...] ^^^^ Just to be clear: the 8-color link scheme isn't "Evan's". I like it well enough, but it wasn't my idea. It was on the CBSP page when I found it; I asked for things to do, and fixing the bugs listed on the CBSP page was one of those things suggested.
Anyways, I've been trying to figure out a way to narrow the scope and submit a patch that fixes 827160. I've tried various shades of purple for the stub color, and none of them seem very distinct from the visited link color. Any suggestions for stub colors that would work better? Are we open to a radically different color (orange, yellow, gray, inverted text, I dunno) for stubs if the change is just localized to Cologne Blue?
~ESP
wikitech-l@lists.wikimedia.org