On 12/21/05, Ben Garney beng@garagegames.com wrote:

var Arnfjr Bjarmason wrote:

...

Update of /cvsroot/wikipedia/extensions In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16873

Added Files: Tidy.php Log Message:

• An extension that adds a tidy tab to all pages

--- NEW FILE: Tidy.php --- (This appears to be a binary file; contents omitted.)

Is there a reason this is showing up as binary..? From a convenience perspective, I'd love to read the code. :) From a CVS standpoint, though, is this an indication the file has the wrong mode?

It's due to stupid logic in the script that parses the file, it thinks a file is binary if it finds any byte with a value less than ' ' (32) and higher than 127 line 5 of that file is the following:

* @author Ævar Arnfjörð Bjarmason avarab@gmail.com

On that line there are three characters and six bytes with chr > 127, or Æ, ö and ð with the first byte being 195 and the second byte being 134, 182 and 176, respectively. So python thinks that file is a binary file, although it obviously isn't.

I'll change the script so that it only checks whether the first five lines contain any characters < ' ', hopefully that will resolve the issue.