On 29/06/07, catrope(a)svn.wikimedia.org <catrope(a)svn.wikimedia.org> wrote: Some quick thoughts: * We like whitespace in our code, and it's nice when people generally follow the house style * Is there a better place for those constants? Seems to me that global defines should be cut down a bit now that we can use class constants. * "ROLLBACK_SUCCES" seems a bit silly; what are you hoping to save by missing one character out? It's going to be a lot less confusing in the long term if you just rename it to what other people would expect. Rob Church