Hi all,
Do we have plans to merge WikiEditor into core, and make it the default (and only) editing toolbar?
If not, I'd like to propose that we do so at some point (perhaps for 1.18?). It's infinitely better than the old one, very useful, extensible and really ought to be the only way forward for MediaWiki. What do other people think?
—Andrew -- Andrew Garrett Wikimedia Foundation agarrett@wikimedia.org
Andrew Garrett wrote:
Do we have plans to merge WikiEditor into core, and make it the default (and only) editing toolbar?
If not, I'd like to propose that we do so at some point (perhaps for 1.18?). It's infinitely better than the old one, very useful, extensible and really ought to be the only way forward for MediaWiki. What do other people think?
Relevant bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=26914.
MZMcBride
Moving WikiEditor into core would involve...
Straightforward changes
- Move the contents of the WikiEditor modules folder to resources/jquery.wikiEditor/ and resources/wikiEditor (removing the "ext." from files that have it) - Move the module registrations to resources/Resources.php - Distribute messages in WikiEditor.i18n.php into core message files - Move configurations in WikiEditor.php to DefaultSettings.php
Messy changes
- Put the logic for adding preferences somewhere - Put the logic for adding modules to edit pages based on preferences somewhere
This results in the WikiEditor code no longer being all in one place. I have always thought that was a downside.
- Trevor
On Fri, May 6, 2011 at 12:34 AM, K. Peachey p858snake@gmail.com wrote:
I do believe the new installer allows the bundling of extensions in the package....
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Fri, May 6, 2011 at 10:56 AM, Trevor Parscal tparscal@wikimedia.org wrote:
Moving WikiEditor into core would involve...
Straightforward changes
- Move the contents of the WikiEditor modules folder to resources/jquery.wikiEditor/ and resources/wikiEditor (removing the "ext." from files that have it) - Move the module registrations to resources/Resources.php - Distribute messages in WikiEditor.i18n.php into core message files - Move configurations in WikiEditor.php to DefaultSettings.php
Messy changes
- Put the logic for adding preferences somewhere - Put the logic for adding modules to edit pages based on preferences somewhere
This results in the WikiEditor code no longer being all in one place. I have always thought that was a downside.
Why don't we have a modules system, where extensions are simply integrated as is into core? Basically, extensions that are found to be essential for MediaWiki could be moved from /extensions to /modules, only needing to change small portions of code to fix references to the directory.
- Ryan
Isn't that essentially a binary rating system, where the only two ratings are "Necessary" and "Optional", depending on their presence in /modules versus /extensions? It's a good idea -- make no mistake -- but let's be deliberate about having only two ratings. ________________________________________
Why don't we have a modules system, where extensions are simply integrated as is into core? Basically, extensions that are found to be essential for MediaWiki could be moved from /extensions to /modules, only needing to change small portions of code to fix references to the directory.
- Ryan
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Sat, May 7, 2011 at 4:02 AM, Ryan Lane rlane32@gmail.com wrote:
On Fri, May 6, 2011 at 10:56 AM, Trevor Parscal tparscal@wikimedia.org wrote:
Moving WikiEditor into core would involve...
Straightforward changes
- Move the contents of the WikiEditor modules folder to resources/jquery.wikiEditor/ and resources/wikiEditor (removing the "ext." from files that have it) - Move the module registrations to resources/Resources.php - Distribute messages in WikiEditor.i18n.php into core message files - Move configurations in WikiEditor.php to DefaultSettings.php
Messy changes
- Put the logic for adding preferences somewhere - Put the logic for adding modules to edit pages based on preferences somewhere
This results in the WikiEditor code no longer being all in one place. I have always thought that was a downside.
Why don't we have a modules system, where extensions are simply integrated as is into core? Basically, extensions that are found to be essential for MediaWiki could be moved from /extensions to /modules, only needing to change small portions of code to fix references to the directory.
I like this idea a lot. It keeps our main code paths clean (if not awfully easy to follow), and simplifies merging extensions into core.
-- Andrew Garrett Wikimedia Foundation agarrett@wikimedia.org
MZMcBride wrote:
Relevant bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=26914.
MZMcBride
Trevor Parscal wrote:
Moving WikiEditor into core would involve...
(...)
On Fri, May 6, 2011 at 12:34 AM, K. Peachey p858snake@gmail.com wrote:
I do believe the new installer allows the bundling of extensions in the package....
Following the comments on that bug (especially Brion's[1]), and the posts on this thread at wikitech-l I suggest the following:
* Implement a backend interface to plug-in (other/any) editor frontends (bug 26914) [2] * Move current core editor (aka "Monobook editor") to an extension for those who want it, do this before 1.18 release. * Make minor adjustments to WikiEditor to use this new hook * Keep WikiEditor in an extension and bundle it with 1.18 or 1.19
Result: When people download/install 1.18 they have WikiEditor bundled by default, they can choose to not install / pull out the WikiEditor extension and/ or plug-in ClassicToolbar instead.
-- Krinkle
[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=26914#c4 [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=26918
On Fri, May 6, 2011 at 1:56 PM, Trevor Parscal tparscal@wikimedia.org wrote:
Messy changes
- Put the logic for adding preferences somewhere - Put the logic for adding modules to edit pages based on preferences somewhere
This results in the WikiEditor code no longer being all in one place. I have always thought that was a downside.
The editing code needs an overhaul anyway. This would be as good a time as any to reorganize and clean this up.
-Chad
wikitech-l@lists.wikimedia.org