CR0: Please review and provide guidance if you are familiar with the code, and decide (CR±1 or CR±2):
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cargo/+/480039/ ** Added new feature: order virtual fields by the order they inserted to list on cargo store ** 2018-December-17 ** Maintainers/Stewards: ???
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleAnalyticsMetri... ** fix: non-ascii page title bug ** 2019-January-20 ** Maintainers/Stewards: ???
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OdbcDatabase/+/48756... ** Fix OdbcDatabase to work under 1.32 and with current ExternalData ** 2019-February-02 ** Maintainers/Stewards: ???
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FirstSteps/+/492460/ ** Convert FirstSteps to use extension registration ** 2019-February-27 ** Maintainers/Stewards: ??? (unmaintained?)
* https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/492485/ ** [bugfix] Remove link to /edithistory from page's edithistory summary. ** 2019-March-17 ** Maintainers/Stewards: ??? (not sure where Pywikibot lists that)
* https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/498773/ ** db::views: Bring back abuse_filter_history table ** 2019-March-25 ** Maintainers/Stewards: WMCS?
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Newsletter/+/499292/ ** Split API messages to a separate file ** 2019-March-26 ** Maintainers/Stewards: ???
CR+1: Please help make a decision (CR±1, CR±2) on these CR+1 patches:
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PipeEscape/+/486043/ ** Convert PipeEscape to use extension registration ** 2019-April-20 ** Maintainers/Stewards: ???
* https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Push/+/492443/ ** Use addJsConfigVars instead of addInlineScript ** 2019-April-09 ** Maintainers/Stewards: ??? (mw.org says Unmaintained)
* https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/429533/ ** ApiEditPage: Don't swap undo and undoafter parameters ** 2019-April-01 ** Maintainers/Stewards: MediaWiki Platform team?
Read https://www.mediawiki.org/wiki/Gerrit/Code_review#By_project how you can get notified of new patches in your code areas of interest.
Thanks in advance for your reviews!
Of last time's 20 listed patches, 1 got -1ed by Santhosh; 3 got +1ed by D3rick01, Thiemo Kreuz, WMDE-Fisch, Pastakhov; 9 got +2ed by D3rick01, Jforrester, Brian Wolff, Xqt, Volans, MarcoAurelio, EBernhardson, Umherirrender; 1 got abandoned.
Maintainers/Stewards data taken from https://www.mediawiki.org/wiki/Developers/Maintainers CR0 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verif... CR+1 source: https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+status:open+label:Verif...
wikitech-l@lists.wikimedia.org