Is there more to be done?
The following code in Parser.php starting at line 165 has a problem. The 'else' needs a left brace following it. But even fixing that there are execution errors.--Nick Pisarro
$doesexist = false ; if ( $doesexist ) { $sql = "SELECT l_from FROM links WHERE l_to={$id}" ; } else $sql = "SELECT cur_title,cur_namespace FROM cur,brokenlinks WHERE bl_to={$id} AND bl_from=cur_id" ; }
$res = wfQuery ( $sql, DB_READ ) ;
On Thu, 26 Feb 2004 12:40:35 -0500, Nick Pisarro wrote:
Is there more to be done?
The following code in Parser.php starting at line 165 has a problem. The 'else' needs a left brace following it. But even fixing that there are execution errors.--Nick Pisarro
<Me too>
Wikimedia developers wikitech-l@Wikipedia.org writes:
But even fixing that there are execution errors.
Such as?
A database query syntax error has occurred. This could be because of an illegal search query (see Searching Lightbox(tm)), or it may indicate a bug in the software. The last attempted database query was: SELECT pc_data FROM parsercache WHERE pc_pageid = 0 AND pc_prefhash = '1!1!1!0!1!1!0!1!0!1!' AND pc_expire > NOW() from within function "". MySQL returned error "1146: Table 'wikidb.parsercache' doesn't exist".
There is no table, "parsercache" in my database, and there is no code yet in phase3 to make it, however, as "$wgEnableParserCache = false;", in DefaultSettings, the code should not be trying to access it.
Nick Pisarro
Yes, a check for $wgEnableParserCache got lost in some recent refactoring. It wasn't noticed immediately since some of us have that table in our test databases. Thanks for the bug report, it might have taken a few more days to find and fix the problem without it.
// E23
Nick Pisarro nickp-at-aperture.com |wikipedia| wrote:
A database query syntax error has occurred. This could be because of an illegal search query (see Searching Lightbox(tm)), or it may indicate a bug in the software. The last attempted database query was: SELECT pc_data FROM parsercache WHERE pc_pageid = 0 AND pc_prefhash = '1!1!1!0!1!1!0!1!0!1!' AND pc_expire > NOW() from within function "". MySQL returned error "1146: Table 'wikidb.parsercache' doesn't exist".
There is no table, "parsercache" in my database, and there is no code yet in phase3 to make it, however, as "$wgEnableParserCache = false;", in DefaultSettings, the code should not be trying to access it.
Nick Pisarro
Wikitech-l mailing list Wikitech-l@Wikipedia.org http://mail.wikipedia.org/mailman/listinfo/wikitech-l
Wikimedia developers wikitech-l@Wikipedia.org writes:
Yes, a check for $wgEnableParserCache got lost in some recent refactoring. It wasn't noticed immediately since some of us have that table in our test databases. Thanks for the bug report, it might have taken a few more days to find and fix the problem without it.
Thanks for fixing this quickly so I could upload my few changes.
I actually keep the installed source on our own source control system, with release, development, and "production" branches so I can merge changes around in a controlled fashion.
Nick Pisarro
wikitech-l@lists.wikimedia.org