-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
tstarling@svn.wikimedia.org wrote:
Revision: 36783 Author: tstarling Date: 2008-06-29 20:02:42 +0000 (Sun, 29 Jun 2008)
Log Message:
Remove hack for old APC bug that's fixed now. Was causing problems for DumpHTML (and probably other command line scripts) because $IP was not the same as dirname(__FILE__), causing double-inclusion.
Does this mean it's safe to remove the .deps.php files for language & skin classes as well?
- -- brion
^_^ Please do, please do, if at all possible, please...
One of the 3 reasons I have my own skins repo for my wiki is that I store skins inside of /var/www/mediawiki/sources/skins, and my actual mediawiki code adjacently inside of ../mediawiki-1.12 and ../mediawiki-trunk. Because the /skins folder is not a subfolder of the MediaWiki source (and there is no reason why it should have to be, considering the directory is completely customizable) the .deps.php files all gave me fatal errors which required me to delete all of them.
If the APC issue is gone, then please do get rid of .deps.php files for the skins, they are only in the way of installations of MediaWiki that share skins inside of a central location.
~Daniel Friesen(Dantman) of: -The Nadir-Point Group (http://nadir-point.com) --It's Wiki-Tools subgroup (http://wiki-tools.com) --Games-G.P.S. (http://ggps.org) -And Wikia ACG on Wikia.com (http://wikia.com/wiki/Wikia_ACG)
Brion Vibber wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
tstarling@svn.wikimedia.org wrote:
Revision: 36783 Author: tstarling Date: 2008-06-29 20:02:42 +0000 (Sun, 29 Jun 2008)
Log Message:
Remove hack for old APC bug that's fixed now. Was causing problems for DumpHTML (and probably other command line scripts) because $IP was not the same as dirname(__FILE__), causing double-inclusion.
Does this mean it's safe to remove the .deps.php files for language & skin classes as well?
- -- brion
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhr8soACgkQwRnhpk1wk467XgCgzTki7iz8PMaaKP+pMcPICOsz UWQAnjLrKa9g/h/PaEThzgM78APTN2Mo =UAov -----END PGP SIGNATURE-----
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Brion Vibber wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
tstarling@svn.wikimedia.org wrote:
Revision: 36783 Author: tstarling Date: 2008-06-29 20:02:42 +0000 (Sun, 29 Jun 2008)
Log Message:
Remove hack for old APC bug that's fixed now. Was causing problems for DumpHTML (and probably other command line scripts) because $IP was not the same as dirname(__FILE__), causing double-inclusion.
Does this mean it's safe to remove the .deps.php files for language & skin classes as well?
I think it needs a double-check. I made the change because I was anxious to get DumpHTML working again, I didn't really do due diligence. I'm pretty sure the worst of the problems in APC were fixed, i.e. crashing and class entry corruption, but there might still be a performance hit.
The segfaults and poor autoloader performance we've been seeing on the site lately started before I made this change.
-- Tim Starling
wikitech-l@lists.wikimedia.org