On Mon, Jul 21, 2008 at 12:24 PM, ialex@svn.wikimedia.org wrote:

Revision: 37884 Author: ialex Date: 2008-07-21 16:24:39 +0000 (Mon, 21 Jul 2008)

Log Message:

Use the internal diff engine if the diff excutable is not found ...

•           $diffs = new Diff( explode( "\n", $before ), explode( "\n", $after ) );
  

•           $format = new UnifiedDiffFormatter();
  

Maybe it would make sense to have diff engine do the fallback to the diff utility, rather than the caller? It seems like $wgExternalDiffEngine currently must be manually set to true to take advantage of utilities like Unix diff. Unless there are problems with the option, it seems like it would be sensible to use command-line utilities automatically if available.