Hello all!
I have not yet started the 1.33.0-wmf.18 train; however, at the end of last week, I noticed some errors that (AFAICT) are regressions in 1.33.0-wmf.17.
There were two new errors that started showing up in 1.33.0-wmf.17:
1. ErrorException from includes/HeaderCallback.php: PHP Notice: Undefined offset: 1[0] 2. includes/specials/pagers/ActiveUsersPager.php: PHP Notice: Undefined index: dir[1]
Neither of these errors were happening at a high enough rate, or with enough of a user impact to trigger a rollback of 1.33.0-wmf.17; however, I added them as blockers for wmf.18 in the hopes that we could address regressions caused from wmf.17 before rolling out wmf.18.
If folks could take a look at these tasks and help me resolve these regressions before we start rollout of a new version that'd be great!
Thanks in advance for your help and attention!
-- Tyler
[0]. https://phabricator.wikimedia.org/T216086 [1]. https://phabricator.wikimedia.org/T216200
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 2/19/19 6:36 AM, Tyler Cipriani wrote:
I have not yet started the 1.33.0-wmf.18 train; however, at the end of last week, I noticed some errors that (AFAICT) are regressions in 1.33.0-wmf.17.
In addition to those, I'm not sure whether we should be pushing out a new train while beta cluster is unusable (locked in read-only mode): https://phabricator.wikimedia.org/T216404.
- -- Legoktm
<quote name="Kunal Mehta" date="2019-02-19" time="15:24:22 -0800">
In addition to those, I'm not sure whether we should be pushing out a new train while beta cluster is unusable (locked in read-only mode): https://phabricator.wikimedia.org/T216404.
It is incredibly unfortunate that the Beta Cluster is down due to the corruption fallout.
However, given that the new train is now already on group0 and the only new issue we've seen thus far is https://phabricator.wikimedia.org/T216561 (with patch merged and ready for backport) I'm inclined to continue the train while being (as always) vigilant.
The cost/benefit of skipping a train is also not great; the added complexity of another week's wroth of changes going out increases our risk.
Thanks for bringing it up,
Greg
wikitech-l@lists.wikimedia.org