Thanks to all who replied to my previous message: http://mail.wikipedia.org/pipermail/wikitech-l/2005-December/032856.html In the end I used TortoiseCVS, which recommended WinMerge for diffs.
Apologies in advance for another newbie question, this is the first time I've worked with CVS. I've finished my patch, and posted it at MediaZilla: http://bugzilla.wikimedia.org/show_bug.cgi?id=04028
How do I add this to the CVS, and more importantly, in which package do I add my changes? Since the feture request is for a Special: page, almost all the code is self-contained, and so it should be fairly safe to upload.
-- Stephen Bain stephen.bain@gmail.com
Stephen Bain wrote:
Thanks to all who replied to my previous message: http://mail.wikipedia.org/pipermail/wikitech-l/2005-December/032856.html In the end I used TortoiseCVS, which recommended WinMerge for diffs.
Apologies in advance for another newbie question, this is the first time I've worked with CVS. I've finished my patch, and posted it at MediaZilla: http://bugzilla.wikimedia.org/show_bug.cgi?id=04028
How do I add this to the CVS, and more importantly, in which package do I add my changes? Since the feture request is for a Special: page, almost all the code is self-contained, and so it should be fairly safe to upload.
Congratulations ! You have coded your first hack for MediaWiki :)
You cant directly add code to CVS unless you have write access. The actual patch submitted in bugzilla with keywords 'patch, need-review' will be reviewed and commented by regulars.
Once it is flagged as 'reviewed' it might be added to the next version of MediaWiki (1.6?).
For special pages, you can maybe convert it to an extension. That would be easier to have it included in the live code. I personally like your idea and think it should be in the main code (but god^Wbrion know if it will really be included).
cheers,
On 05/12/05, Stephen Bain stephen.bain@gmail.com wrote:
Apologies in advance for another newbie question, this is the first time I've worked with CVS. I've finished my patch, and posted it at MediaZilla: http://bugzilla.wikimedia.org/show_bug.cgi?id=04028
You need to be granted rights to the CVS repository to do this - although, like a wiki, you can revert most things in CVS, you could also cause a lot of havoc, so this isn't an automatic right. The easiest thing is just to wait for someone else to check your code over and submit it for you, but if you seem trustworthy, the main developers have generally been fairly generous in giving out such rights.
How do I add this to the CVS, and more importantly, in which package do I add my changes? Since the feture request is for a Special: page, almost all the code is self-contained, and so it should be fairly safe to upload.
Well, you would add it - if you had the required permissions - to the same place all the software is, i.e. in the 'phase3' module. Unless what you're writing is intended to be an extension, not part of the generally distributed code, in which case it goes in a separate module called 'extensions', IIRC.
If this is just your first patch, my advice would be to wait and see if anyone reviews the patch on bugzilla (which someone has labelled 'need-review' for you) and either checks it in or points out a fatal flaw.
-- Rowan Collins BSc [IMSoP]
wikitech-l@lists.wikimedia.org