Hi, i will work on improving DB2 mediawiki port in 1.17. Currently there is a problem with missing template class so i cant even run installer. Can you give me some schedule when will be 1.17 in good enough state to let me work on database backend?
PHP Fatal error: Class 'BaseTemplate' not found in /home/hsn/public_html/phase3/skins/Vector.php on line 344
If this is not developer mailing list please let me know.
2010/12/31 Radim Kolar hsn@sendmail.cz:
Hi, i will work on improving DB2 mediawiki port in 1.17. Currently there is a problem with missing template class so i cant even run installer. Can you give me some schedule when will be 1.17 in good enough state to let me work on database backend?
PHP Fatal error: Class 'BaseTemplate' not found in /home/hsn/public_html/phase3/skins/Vector.php on line 344
There are no big stability problems with either 1.17 (/branches/REL1_17 , which you don't seem to be running because none of the BaseTemplate code is in there) or trunk (/trunk/phase3). The error you're running into is just someone making a silly mistake (not putting the BaseTemplate class in the AutoLoader) and should already be fixed, from looking at the code. This kind of thing happens in development code every now and then, and it hardly ever takes more than a few hours to be noticed and fixed (usually much faster, even).
As for 1.17 vs. trunk: your DB2 development work should be done in /trunk/phase3 , that's where all development happens. At this point 1.17 is sort of being frozen, so only bugfixes and the like are merged from trunk to the 1.17 branch. This means your DB2 work won't be part of 1.17 (not will any other new features), but it'll be in 1.18 if it's sufficiently stable by then.
If this is not developer mailing list please let me know.
No worries, you're in the right place. MediaWiki developers also hang out on IRC (#mediawiki on freenode), you're welcome there for getting advice from fellow developers and telling them the next time trunk breaks like that :)
Roan Kattouw (Catrope)
On 10-12-31 05:59 AM, Roan Kattouw wrote:
2010/12/31 Radim Kolarhsn@sendmail.cz:
Hi, i will work on improving DB2 mediawiki port in 1.17. Currently there is a problem with missing template class so i cant even run installer. Can you give me some schedule when will be 1.17 in good enough state to let me work on database backend?
PHP Fatal error: Class 'BaseTemplate' not found in /home/hsn/public_html/phase3/skins/Vector.php on line 344
There are no big stability problems with either 1.17 (/branches/REL1_17 , which you don't seem to be running because none of the BaseTemplate code is in there) or trunk (/trunk/phase3). The error you're running into is just someone making a silly mistake (not putting the BaseTemplate class in the AutoLoader) and should already be fixed, from looking at the code. This kind of thing happens in development code every now and then, and it hardly ever takes more than a few hours to be noticed and fixed (usually much faster, even). Roan Kattouw (Catrope)
I would say it sounds more like someone is running 1.17 core with a 1.18 skins folder, but looking at REL1_17, it looks like when the larger portions of my skin system improvements (BaseTemplate) we're reverted in the 1.17 branch after branching to make them part of 1.18 instead of 1.17 the reverter missed the portions of those commits they were reverting which were inside of the skins/ folder.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
On 10-12-31 06:49 AM, Daniel Friesen wrote:
On 10-12-31 05:59 AM, Roan Kattouw wrote:
2010/12/31 Radim Kolarhsn@sendmail.cz:
Hi, i will work on improving DB2 mediawiki port in 1.17. Currently there is a problem with missing template class so i cant even run installer. Can you give me some schedule when will be 1.17 in good enough state to let me work on database backend?
PHP Fatal error: Class 'BaseTemplate' not found in /home/hsn/public_html/phase3/skins/Vector.php on line 344
There are no big stability problems with either 1.17 (/branches/REL1_17 , which you don't seem to be running because none of the BaseTemplate code is in there) or trunk (/trunk/phase3). The error you're running into is just someone making a silly mistake (not putting the BaseTemplate class in the AutoLoader) and should already be fixed, from looking at the code. This kind of thing happens in development code every now and then, and it hardly ever takes more than a few hours to be noticed and fixed (usually much faster, even). Roan Kattouw (Catrope)
I would say it sounds more like someone is running 1.17 core with a 1.18 skins folder, but looking at REL1_17, it looks like when the larger portions of my skin system improvements (BaseTemplate) we're reverted in the 1.17 branch after branching to make them part of 1.18 instead of 1.17 the reverter missed the portions of those commits they were reverting which were inside of the skins/ folder.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
Ok, on closer looked, it was reverted correctly inside of the 1.17 branch by the reverter. But then http://svn.wikimedia.org/viewvc/mediawiki?view=revision&revision=79129 went and re-introduced half the code, leaving things in a wierd state of limbo where parts of the code are from 1.17, parts are from the code meant to be in 1.18, and some of the files are mixed...
2010/12/31 Daniel Friesen lists@nadir-seen-fire.com:
Ok, on closer looked, it was reverted correctly inside of the 1.17 branch by the reverter. But then http://svn.wikimedia.org/viewvc/mediawiki?view=revision&revision=79129 went and re-introduced half the code, leaving things in a wierd state of limbo where parts of the code are from 1.17, parts are from the code meant to be in 1.18, and some of the files are mixed...
I'll take a look at cleaning this up right now. I'll do this by reverting r79129 and merging the revisions it merged more carefully and in smaller batches.
Roan Kattouw (Catrope)
2010/12/31 Roan Kattouw roan.kattouw@gmail.com:
I'll take a look at cleaning this up right now. I'll do this by reverting r79129 and merging the revisions it merged more carefully and in smaller batches.
This is fixed now. I didn't go to such extremes as to completely revert and re-do r79129; instead I did that just for Vector.php . As Daniel correctly pointed out, the breakage was caused by a botched merge (r79129) that accidentally merged half the BaseTemplate changes to 1.17, causing it to break because the other half was missing.
I've seen more things wrong with the r79129 merge (all extensions changes missing, changes to mediawiki.js missing), so I'll audit the entire thing by hand and clean it up where needed.
Roan Kattouw (Catrope)
On 31.12.2010, 16:59 Roan wrote:
As for 1.17 vs. trunk: your DB2 development work should be done in /trunk/phase3 , that's where all development happens. At this point 1.17 is sort of being frozen, so only bugfixes and the like are merged from trunk to the 1.17 branch. This means your DB2 work won't be part of 1.17 (not will any other new features), but it'll be in 1.18 if it's sufficiently stable by then.
I see no problem with backporting DB2 installer and DB class to 1.17 as long as it is clearly marked as experimental. Of course, we must be much more cautious with other changes in core needed for proper DB2 support.
2010/12/31 Max Semenik maxsem.wiki@gmail.com:
I see no problem with backporting DB2 installer and DB class to 1.17 as long as it is clearly marked as experimental. Of course, we must be much more cautious with other changes in core needed for proper DB2 support.
Sounds reasonable. If DB2 support is sort-of-ready before the 1.17 release and doesn't require non-trivial core changes, we can do that.
So Radim, please do all development in trunk, then if and when we decide the code is 1.17-ready we'll merge it into REL1_17. This is what we do for everything else too.
Roan Kattouw (Catrope)
On Fri, Dec 31, 2010 at 11:41 AM, Max Semenik maxsem.wiki@gmail.com wrote:
I see no problem with backporting DB2 installer and DB class to 1.17 as long as it is clearly marked as experimental. Of course, we must be much more cautious with other changes in core needed for proper DB2 support.
I doubt that the Installer/Updater classes will be done in time. If they are, we can of course merge them trivially.
I only say that because it's taken months and nobody's bothered working on Postgres either. We're quickly approaching a release with broken Postgres install support and nobody seems to care.
-Chad
wikitech-l@lists.wikimedia.org