On 10/05/06, hashar@svn.leuksman.com hashar@svn.leuksman.com wrote:
Die with a backtrace when using User::isBureaucrat User::isDeveloper User::isSysop Related to #2498 and helps a bit bug 700: Code quality issues (tracking)
Why not grep the existing extension files, etc. and the rest of the code, and remove them all now? Seems wasteful to keep dud code in the source and hold back on removing it until winter.
Rob Church
Rob Church wrote:
On 10/05/06, hashar@svn.leuksman.com hashar@svn.leuksman.com wrote:
Die with a backtrace when using User::isBureaucrat User::isDeveloper User::isSysop Related to #2498 and helps a bit bug 700: Code quality issues (tracking)
Why not grep the existing extension files, etc. and the rest of the code, and remove them all now? Seems wasteful to keep dud code in the source and hold back on removing it until winter.
Hello,
I looked at the extensions in our trunk and found the following:
$ egrep -iR 'is(Bureau|Devel|Sysop)' * ShowProcesslist.php: if ( !$wgUser->isDeveloper() ) { Userip.php: if ( ! $wgUser->isSysop() ) { $
The call in Userip.php is only made if $wgVersion match 1.4. I am not sure ShowProcesslist.php is worse migrating it, we probably have to make the extension add some rights but I am too lazy to do it tonight.
The reason I have put traceback is that when 1.7 is out (in some months), extensions coder will have a clean error log (just like PHP5 is raising E_STRICT error when using var which was valid in PHP4).
Feel free to remove them in trunk though :) That was just a proposal.
cheers,
wikitech-l@lists.wikimedia.org