MediaWiki is a mature, living breathing beast. When making lots and lots of little tweaks, please try to make sure they actually work correctly prior to committing.
I'm becoming convinced that a huge benefit of the git migration will be in moving to pre-commit review. If it doesn't work, don't let it into to core yet... The very idea what we can have a big "review backlog" on things ALREADY COMMITTED is a large part of why we have so many regressions when we finally catch up and update.
That is all; please go on about your business, citizens.
</rant>
-- brion vibber (bvibber @ wikimedia.org)
* Brion Vibber bvibber@wikimedia.org [Tue, 20 Dec 2011 14:46:07 -0800]:
MediaWiki is a mature, living breathing beast. When making lots and
lots
of little tweaks, please try to make sure they actually work correctly prior to committing.
I'm becoming convinced that a huge benefit of the git migration will
be
in moving to pre-commit review. If it doesn't work, don't let it into to core yet... The very idea what we can have a big "review backlog" on things ALREADY COMMITTED is a large part of why we have so many regressions when we finally catch up and update.
That is all; please go on about your business, citizens.
</rant>
Will the pre-commit review work for non-Wikimedia extension commits, or that would be impossible due to shortage of reviewers? How will the commit queue work for non-Wikimedia extensions? Dmitriy
On Wed, Dec 21, 2011 at 01:16, Dmitriy Sintsov questpc@rambler.ru wrote:
Will the pre-commit review work for non-Wikimedia extension commits, or that would be impossible due to shortage of reviewers? How will the commit queue work for non-Wikimedia extensions?
AIUI:
Extensions will default to having no gating/reviews. (if you have access to push to extensions at all then you have push access to all extensions that don't ask for a different setup) They can use gerritt if they like and if using gerritt they can specify their own list/criteria for the gatekeeper users.
There will be 2 (at least) meta modules which in turn just have git submodules. One will have all extensions and will be updated with new commit IDs by commit/push hooks on the individual extension modules. One will have just the extensions used by WMF. I'm not sure how it will be updated but I imagine one possibility is to do updates to WMF extensions or others sufficiently gated automatically and do manual updates (and simultaneously reviews) on updates to extensions with more open push control.
-Jeremy
wikitech-l@lists.wikimedia.org