Hi Steinsplitter, On 16 July 2015 at 09:00, Steinsplitter Wiki <steinsplitter-wiki(a)live.com> wrote: That doesn't really answer Brion's question. What would prevent it from continuing to run while it is being rewritten? Dan -- Dan Garry Lead Product Manager, Discovery Wikimedia Foundation

(commenting on this as I tried to debug the code previously) The code currently: * is independent from any maintained mw api libraries * use self defined api parameters * uses php's curl, which has quite weird https support * has doc strings in de, which I can't read * generates tons of php warnings * and does not check whether upload / page save is successfully done or not The bot have failed when: * a few weeks ago from the https switch * currently from session / token-related issue (not entirely sure) Rewrite attempts have been made, but: * the code barely make any sense (not OOP, reduced indentation, tons of bugs, etc.) * lack of time to do complete rewrite

No need to rewrite then because Rillke will fix the rotate link java-script. :-) > Date: Thu, 16 Jul 2015 12:21:10 -0500 > From: gtisza(a)wikimedia.org > To: wikitech-l(a)lists.wikimedia.org > Subject: Re: [Wikitech-l] Provide a well-performing API to rotate an image > > > On Thu, Jul 16, 2015 at 11:19 AM, YiFei &lt;zhuyifei1999(a)gmail.com&gt; wrote: > > > >> That doesn't really answer Brion's question. What would prevent it from > > >> continuing to run while it is being rewritten? > > > lack of time. > > (commenting on this as I tried to debug the code previously) > > The code currently: > > * is independent from any maintained mw api libraries > > * use self defined api parameters > > * uses php's curl, which has quite weird https support > > * has doc strings in de, which I can't read > > * generates tons of php warnings > > * and does not check whether upload / page save is successfully done or not > > > > The bot have failed when: > > * a few weeks ago from the https switch > > * currently from session / token-related issue (not entirely sure) > > > > Rewrite attempts have been made, but: > > * the code barely make any sense (not OOP, reduced indentation, tons of > > bugs, etc.) > > * lack of time to do complete rewrite > > > > > > > >> Date: Thu, 16 Jul 2015 09:05:11 -0500 > > >> From: dgarry(a)wikimedia.org > > >> To: wikitech-l(a)lists.wikimedia.org > > >> Subject: Re: [Wikitech-l] Provide a well-performing API to rotate an > > image > > >> > > >> Hi Steinsplitter, > > >> > > >> On 16 July 2015 at 09:00, Steinsplitter Wiki < > > steinsplitter-wiki(a)live.com&gt; > > >> wrote: > > >> > > >>>> Out of curiosity what is the problem with the bot that prevents it > > from > > >>>> working? > > >>> It is very old and bad written and needs a complete rewrite. > > >> > > >> That doesn't really answer Brion's question. What would prevent it from > > >> continuing to run while it is being rewritten? > > >> > > >> Dan > > >> > > >> -- > > >> Dan Garry > > >> Lead Product Manager, Discovery > > >> Wikimedia Foundation > > >> _______________________________________________ > > >> Wikitech-l mailing list > > >> Wikitech-l(a)lists.wikimedia.org > > >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > > > > > _______________________________________________ > > > Wikitech-l mailing list > > > Wikitech-l(a)lists.wikimedia.org > > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > > > _______________________________________________ > > Wikitech-l mailing list > > Wikitech-l(a)lists.wikimedia.org > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Ok, I've thrown together a preliminary patch to move the actual rotation for ApiImageRotate to the job queue: https://gerrit.wikimedia.org/r/#/c/225097/ Haven't had a chance to test it yet, so there's probably a typo or two still hiding in there. Steinsplitter, will there be a (more limited) bot hitting this API action, or will people need a user-interface for it in the near term? It shouldn't be too hard to rig up some JS buttons... The primary difficulty I see is with being able to see whether there's a pending rotation; in case it's delayed you don't want to accidentally queue up multiple rotations! Once something's fired into the job queue I don't think we have a good way to query it. (TimedMediaHandler shows queued transcode jobs, but maintains its own secondary database table to track them...) Also, I had a good talk with Trevor at the Wikimania hackathon about non-destructive image editing; somewhere down the road we should be able to integrate this sort of thing into the thumbnailing in a way that's more user-friendly and also allows for cropping and some basic filters. But I don't think we have to wait on that to help folks out for now by fixing up the disabled API action... -- brion On Thu, Jul 16, 2015 at 9:16 AM, Brion Vibber &lt;bvibber(a)wikimedia.org&gt; wrote:

Brion Vibber wrote: In my opinion, we need to solve image rotation as part of a larger project to support in-browser rasterized image manipulation. A bot shouldn't be necessary here. We should have the ability, in a Web browser, to crop, rotate, and make other basic manipulations to rasterized images. The fact that we have a media repository using software called MediaWiki that doesn't include an in-browser basic photo editor is pretty silly. MZMcBride

Apologies if I'm missing something but is there any reason why we can't do image rotation on the client using the canvas JavaScript api? On Thu, Jul 16, 2015 at 3:45 PM, MZMcBride &lt;z(a)mzmcbride.com&gt; wrote: Agreed! Most of that probably should be non-destructive editing that keeps the original and applies crop/rotate/filters along with thumbnailing as necessary. That'll take some more infrastructure work though. Of course if you're going to draw on a picture that'll require uploading a new version. -- brion _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l