-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

aaron@svn.wikimedia.org wrote:

Filecache should check &useskin. This should be backported.

[snip]

Modified: trunk/phase3/includes/Article.php && ($wgUser->isAnon()) && (!$wgUser->getNewtalk()) && ($this->mTitle->getNamespace() != NS_SPECIAL )

• 	&& (!isset($useskin))
  && (empty( $action ) || $action == 'view')
  && (!isset($oldid))
  && (!isset($diff))
  

Ewww, scary old code. :D

Probably this should be changed from checking every parameter we can think of that might show up to just checking if we're using the canonical view URL -- the same logic that currently controls whether we're going to tell Squid to cache the page should control use of the file cache.

That would be more future-proof and proof against funky extension parameters.

- -- brion