`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Thank you,
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
Le 26/05/12 20:02, Amir E. Aharoni a écrit :
`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Which version do you use? What is the next version? ;-D
I use git-review directly from their git repo, I dont have any issue.
2012/5/26 Antoine Musso hashar+wmf@free.fr:
Le 26/05/12 20:02, Amir E. Aharoni a écrit :
`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Which version do you use? What is the next version? ;-D
1.16 -> 1.17.
Le 26/05/12 20:54, Amir E. Aharoni wrote: <snip>
1.16 -> 1.17.
You should upgrade, 1.17 will bring you:
- while downloading a change (-d), if the local branch already exists, git-review will now attempt to update the local branch.
- New -l switch list changes pending review for the current project.
- X Forwarding disabled
- Now run `git remote update` to make sure local repositories are up to date. That one will prevents the issue people add some weeks ago cause their 'gerrit' repo was lagging behind.
- push changes to refs/publish instead of refs/for, that is a change made in Gerrit 2.2.2.
- Fixed hook installation for git with submodules
Half of those six changes have been made by us ;-)
2012/5/27 Antoine Musso hashar+wmf@free.fr:
Le 26/05/12 20:54, Amir E. Aharoni wrote:
<snip> > 1.16 -> 1.17.
You should upgrade, 1.17 will bring you:
- while downloading a change (-d), if the local branch already exists, git-review will now attempt to update the local branch.
- New -l switch list changes pending review for the current project.
- X Forwarding disabled
- Now run `git remote update` to make sure local repositories are up to date. That one will prevents the issue people add some weeks ago cause their 'gerrit' repo was lagging behind.
- push changes to refs/publish instead of refs/for, that is a change made in Gerrit 2.2.2.
- Fixed hook installation for git with submodules
Half of those six changes have been made by us ;-)
Cool! Thank you for the details.
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore
On 26/05/12 20:02, Amir E. Aharoni wrote:
`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Thank you,
It has been telling me that for a long time. Yet the proposed command to update (pip install -U git-review) dies with exec(open("git-review", "r")) TypeError: exec() arg 1 must be a string, bytes or code object
So well, I just ignore it :)
Platonides Platonides@gmail.com wrote:
On 26/05/12 20:02, Amir E. Aharoni wrote:
`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Thank you,
It has been telling me that for a long time. Yet the proposed command to update (pip install -U git-review) dies with exec(open("git-review", "r")) TypeError: exec() arg 1 must be a string, bytes or code object
So well, I just ignore it :)
You can try to download it by hand from
http://pypi.python.org/pypi/git-review#downloads
it's just one python script.
//Saper
I couldn't get it to update (Mac OS X).
Reported in Bugzilla: https://bugzilla.wikimedia.org/37135
-- Krinkle
Am 26.05.2012 20:02, schrieb Amir E. Aharoni:
`git review' says that "a new version of git-review is availble on PyPI".
The last update created some unwanted surprises, so I decided to avoid updating it for now. What do our Git experts suggest?
Thank you,
Grmbl. I updated git-review on my Win7 system and now I am unable sending to Gerrit:
Ray42@RAY-PC /d/F_Programmierung/xampp/htdocs/core/extensions/EducationProgram (i18nfixes) $ git review Traceback (most recent call last): File "c:\Python27\Scripts\git-review", line 735, in <module> main() File "c:\Python27\Scripts\git-review", line 704, in main if not set_hooks_commit_msg(remote, hook_file): File "c:\Python27\Scripts\git-review", line 148, in set_hooks_commit_msg os.chmod(target_file, os.path.stat.S_IREAD | os.path.stat.S_IEXEC) WindowsError: [Error 2] Das System kann die angegebene Datei nicht finden: '.git\hooks\commit-msg'
(the last sentence means: "The system cannot find the file '.git\hooks\commit-msg'")
Any ideas how to fix this?
Raimond.
Le 30/05/12 08:55, Raimond Spekking a écrit :
(the last sentence means: "The system cannot find the file '.git\hooks\commit-msg'")
Any ideas how to fix this?
Set up your hook on that repository?
http://www.mediawiki.org/wiki/Git/Workflow has the answer:
--------------------------------------------------------------------- First, you need to download a pre-commit hook script and place it in the right directory in your cloned copy of the repository. The script is available from https://gerrit.wikimedia.org/r/tools/hooks/commit-msg and must be placed in the repository sub directory .git/hooks/
1) With a browser: Download the script from the repo using "Save As ..." then browse to wikimedia-git-repos/examples/.git/hooks/. Voilà!
2) With wget: Change to the repository directory (for example, cd wikimedia-git-repos/examples/ wget -P .git/hooks https://gerrit.wikimedia.org/r/tools/hooks/commit-msg
3) With curl: curl https://gerrit.wikimedia.org/r/tools/hooks/commit-msg > .git/hooks/commit-msg
You also need to ensure the hook is executable. In Linux you do this with: chmod u+x .git/hooks/commit-msg
When ever you commit a change locally, the hook script will generate a unique Change-Id for you. ---------------------------------------------------------------------
Am 30.05.2012 11:00, schrieb Antoine Musso:
Le 30/05/12 08:55, Raimond Spekking a écrit :
(the last sentence means: "The system cannot find the file '.git\hooks\commit-msg'")
Any ideas how to fix this?
Set up your hook on that repository?
Yeah I missed that. Thanks for help :-)
But to excuse my question: The former git-review has done this automatically during the first commit of an extensions.
Raimond.
Raimond Spekking raimond.spekking@gmail.com wrote:
os.chmod(target_file, os.path.stat.S_IREAD | os.path.stat.S_IEXEC)WindowsError: [Error 2] Das System kann die angegebene Datei nicht finden: '.git\hooks\commit-msg'
(the last sentence means: "The system cannot find the file '.git\hooks\commit-msg'")
Any ideas how to fix this?
Maybe it is now related to the fact that if git submodules are used and relatively new git is used and the moon is waning there might no longer be ".git" subdirectory in the submodule (i.e. extension) but there is only one two levels below.
I think aaronsw fixed this upstream with this change:
https://review.openstack.org/#/c/7166/
(it got merged, and should be included in 1.17, the latest of git-review).
//Saper
wikitech-l@lists.wikimedia.org