[PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

List overview All Threads
Download

newer

older

Joining SQL Dump Files

$1 Billion in Grants available

Emmanuel Engelhart

31 Jul 2004 31 Jul '04

11:45 a.m.

Hi Small patch. Maybe not the best solution, but simple and not very dirty. Makes a merge of correct template args to recover entire wikilinks [[(...)]] Cordialy Emmanuel Engelhart -- ------------------------------------------------------------------------- Le bon sens consiste beaucoup à connaitre la nuance des choses. Montesquieu, "de l'esprit des lois" ------------------------------------------------------------------------- Emmanuel Engelhart ICQ UIN : 53388731 TEL (+49)(0)6.22.15.88.03.31

Attachments:

Parser.patch (application/octet-stream — 1.3 KB)

Show replies by thread

Timwi

31 Jul 31 Jul

1:10 p.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Emmanuel Engelhart wrote:

...

Small patch. Maybe not the best solution, but simple and not very dirty. Makes a merge of correct template args to recover entire wikilinks [[(...)]]

It has a little bug: Suppose you have something like {{template|var1=Here is a [[link]] and here is [[link|another]].}} Your patch would not work properly in this case. Please could you change this: + if((strpos($args[$i], "[[") !== false) && (strpos($args[$i], "]]") === false) ) { in such a way that it essentially says "if number of '[['s in $args[$i] greater than number of ']]'s"? Additionally, please use tabs at the beginning of lines, and please use 'diff -u' to create your patches. Thanks! Timwi

Emmanuel Engelhart

1:43 p.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

On Sat, 31 Jul 2004 14:10:06 +0100 Timwi <timwi(a)gmx.net> wrote:

...

Emmanuel Engelhart wrote:

Small patch. Maybe not the best solution, but simple and not very dirty. Makes a merge of correct template args to recover entire wikilinks [[(...)]]

True, new version correcting this bug. Emmanuel -- ------------------------------------------------------------------------- La noirceur porte plusieurs masques, aucun n'est aussi dangeureux que celui de la vertu. ------------------------------------------------------------------------- Emmanuel Engelhart ICQ UIN : 53388731 TEL (+49)(0)6.22.15.88.03.31

Timwi

2:10 p.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Emmanuel Engelhart wrote:

...

True, new version correcting this bug.

Again, *please* use tabs to indent lines in the future. I've fixed this for you now and committed it. Oh, and I've also changed for ( $i = 0; $i < $argc; $i++ ) { to for ( $i = 0; $i < $argc-1; $i++ ) { because once there's only a single argument left, you don't want to try to merge it with the non-existant next. Thanks, Timwi

Emmanuel Engelhart

2:28 p.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

On Sat, 31 Jul 2004 15:10:53 +0100 Timwi <timwi(a)gmx.net> wrote:

...

Emmanuel Engelhart wrote:

True, new version correcting this bug.

Ok, sorry for not using tabs... but sometimes, my emacs php-mode seems to have difficulties...But I will solve the problem or understand the mode ;) Emmanuel -- ------------------------------------------------------------------------- Il y a deux produits majeurs qui sont sortis de Berkeley: Le LSD et BSD. Nous ne pensons pas que ce soit une coïncidence. ------------------------------------------------------------------------- Emmanuel Engelhart ICQ UIN : 53388731 TEL (+49)(0)6.22.15.88.03.31

Brion Vibber

1 Aug 1 Aug

3:22 a.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Timwi wrote:

...

Emmanuel Engelhart wrote:

True, new version correcting this bug.

Again, *please* use tabs to indent lines in the future. I've fixed this for you now and committed it.

Seems pretty straightforward, I've gone ahead and copied it to the 1.3 branch and installed it. -- brion vibber (brion @ pobox.com)

Yann Forget

9:37 a.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Hi all, Le Sunday 01 August 2004 05:22, Brion Vibber a écrit :

...

Timwi wrote:

Emmanuel Engelhart wrote: > True, new version correcting this bug.

Seems pretty straightforward, I've gone ahead and copied it to the 1.3 branch and installed it. -- brion vibber (brion @ pobox.com)

Many thanks to Emmanuel and Brion for this fix. This bug was quite annoying. Yann -- http://www.non-violence.org/ | Site collaboratif sur la non-violence http://www.forget-me.net/ | Alternatives sur le Net http://fr.wikipedia.org/ | Encyclopédie libre http://www.forget-me.net/pro/ | Formations et services Linux

Emmanuel Engelhart

9:51 a.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

On Sun, 1 Aug 2004 11:37:45 +0200 Yann Forget <yann(a)forget-me.net> wrote:

...

Hi all, Le Sunday 01 August 2004 05:22, Brion Vibber a écrit :

Timwi wrote:

Emmanuel Engelhart wrote: > True, new version correcting this bug.

Seems pretty straightforward, I've gone ahead and copied it to the 1.3 branch and installed it. -- brion vibber (brion @ pobox.com)

Many thanks to Emmanuel and Brion for this fix. This bug was quite annoying.

And Timwi... of course. Emmanuel -- ------------------------------------------------------------------------- L'informatique, en tant que discipline, ne traite pas plus des ordinateurs que l'astronomie le fait les téléscopes. -- E. W. Dijkstra ------------------------------------------------------------------------- Emmanuel Engelhart ICQ UIN : 53388731 TEL (+49)(0)6.22.15.88.03.31

Timwi

3:59 p.m.

New subject: [PATCH] [ 965725 ] Pipe-character (|) in instantiated Templates

Emmanuel Engelhart wrote:

...

And Timwi... of course.

Hee. I get thanked for complaining about indentation tabs. :) Timwi

7201

days inactive

7202

days old

wikitech-l@lists.wikimedia.org

Manage subscription

8 comments

4 participants

tags (0)

participants (4)

Brion Vibber
Emmanuel Engelhart
Timwi
Yann Forget