Fixing the test means updating the Parser to match the new "correct" test. Other than that, I don't see a reason not to... -- Jim R. Wilson (jimbojw) On Nov 15, 2007 9:29 AM, David Gerard &lt;dgerard(a)gmail.com&gt; wrote: > On 15/11/2007, Magnus Manske &lt;magnusmanske(a)googlemail.com&gt; wrote: > > > Also, the "expected results" in the parser tests are sometimes rather > > MediaWiki-specific. Does it matter if there's a space after <li>? It's > > not rendered anyway. Or, "X\nY" vs. "X Y" in HTML - no difference, > > AFAIK (except in <pre>). These "non-errors" make up quite a few > > "wrong" results in my tests. > > > > > - d. > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l(a)lists.wikimedia.org > http://lists.wikimedia.org/mailman/listinfo/wikitech-l >

On 11/15/07, Steve Bennett &lt;stevagewp(a)gmail.com&gt; wrote: Yep. You need to be careful, though, with things like <pre>.

On 11/16/07, Steve Bennett &lt;stevagewp(a)gmail.com&gt; wrote: Right, so what happens if someone has a snippet of code on a line with an initial space on a wiki page, and the new parser changes the whitespace there? Different rendering. I'm not saying we have to fret about that too much, just keep in mind that XML whitespace compression isn't totally consistent.

On 11/17/07, Steve Bennett &lt;stevagewp(a)gmail.com&gt; wrote: I realize, and that's not the issue I was thinking of. But what I *was* thinking of is no issue if there are parser tests checking preservation of whitespace inside <pre> constructs, so it's not really an issue after all.

On 11/17/07, Edward Z. Yang &lt;edwardzyang(a)thewritingpot.com&gt; wrote: You still have to normalize the text nodes, so you don't gain much of anything.