Changes to parser - link endings. - Wikitech-l - lists.wikimedia.org

List overview All Threads
Download

Changes to parser - link endings.

Extending wikilinks syntax

Announcing Semantic Bundle

Mark Clements (HappyDog)

24 Jun 2009 24 Jun '09

3:19 p.m.

I've just noticed that on English Wikipedia links such as [[Pink Floyd]]'s no longer include the 's as part of the resulting link. Is this a parser bug, or a deliberate change in the way links are being parsed? I don't recall seeing an announcement about it. - Mark Clements (HappyDog)

Reply

Show replies by thread

Petr Kadlec

24 Jun 24 Jun

3:36 p.m.

2009/6/24 Mark Clements (HappyDog) <gmane(a)kennel17.co.uk>uk>:

I've just noticed that on English Wikipedia links such as [[Pink Floyd]]'s no longer include the 's as part of the resulting link. Is this a parser bug, or a deliberate change in the way links are being parsed? I don't recall seeing an announcement about it.

This has been changed in r38751 due to bug #15035, see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/38751 and https://bugzilla.wikimedia.org/show_bug.cgi?id=15035 I would say the apostrophe change is just a (possibly unintended?) side effect of the change. -- [[cs:User:Mormegil | Petr Kadlec]]

Reply

Aryeh Gregor

4:11 p.m.

On Wed, Jun 24, 2009 at 9:36 AM, Petr Kadlec<petr.kadlec(a)gmail.com> wrote:

This has been changed in r38751 due to bug #15035, see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/38751 and https://bugzilla.wikimedia.org/show_bug.cgi?id=15035 I would say the apostrophe change is just a (possibly unintended?) side effect of the change.

r38751 just reverted r36253 and restored how the link trail had always behaved. The change was only on trunk from June 13 to August 7, 2008, and probably on Wikipedia for only a couple of weeks. It would have nothing to do with any recent change. Are you sure that [[Pink Floyd]]'s ever worked in the past? We could probably special-case <'s>, but we likely don't want to trigger off <s'> lest we mess up things like <"I don't know what these '[[linktrail]]s' you're talking about are", she said.>. So it's probably most consistent to stick with what we have now, and have always had AFAICT.

Reply

Steve Bennett

25 Jun 25 Jun

11:29 a.m.

On Wed, Jun 24, 2009 at 11:19 PM, Mark Clements (HappyDog)<gmane(a)kennel17.co.uk> wrote:

I've just noticed that on English Wikipedia links such as [[Pink Floyd]]'s no longer include the 's as part of the resulting link. Is this a parser bug, or a deliberate change in the way links are being parsed? I don't recall seeing an announcement about it.

Since we're debating the merits of the change, IMHO the 's should not be linked. Can't think of any compelling reasons why, but aesthetically it seems better to me. Steve

Reply

Mark Clements (HappyDog)

12:43 p.m.

"Steve Bennett" wrote in message news:b8ceeef70906250229s1211f650nbb5dc10d4a13ebce@mail.gmail.com...

On Wed, Jun 24, 2009 at 11:19 PM, Mark Clements (HappyDog) wrote:

I've just noticed that on English Wikipedia links such as [[Pink Floyd]]'s no longer include the 's as part of the resulting link. Is this a parser bug, or a deliberate change in the way links are being parsed? I don't recall seeing an announcement about it.

Since we're debating the merits of the change, IMHO the 's should not be linked. Can't think of any compelling reasons why, but aesthetically it seems better to me.

I noticed the problem here: http://en.wikipedia.org/wiki/Neil%27s_Heavy_Concept_Album The second paragraph has about 6 instances of this in quick succession, and in my opinion it makes the paragraph needlessly difficult to read. (btw, it also has instance of s', as in Sex Pistols', and this looks fine, so I don't think this case needs to be handled in the same way). I just tested that paragraph in 1.6.10, and it is rendered the same, so this doesn't appear to be a regression (unless the change happened prior to that, or it has changed twice since then) so it seems I must have just been mis-remembering it. However I personally think it would be improvement. - Mark Clements (HappyDog)

Reply

Aryeh Gregor

4:01 p.m.

On Thu, Jun 25, 2009 at 6:43 AM, Mark Clements (HappyDog)<gmane(a)kennel17.co.uk> wrote:

I just tested that paragraph in 1.6.10, and it is rendered the same, so this doesn't appear to be a regression (unless the change happened prior to that, or it has changed twice since then) so it seems I must have just been mis-remembering it. However I personally think it would be improvement.

Well, it would be a change of a few characters. So it just depends on whether we want it. I'd say not, just because we've had it forever and no one (including you until just now) seems to have had much problem with it.

Reply

Steve Bennett

26 Jun 26 Jun

3:19 a.m.

On Thu, Jun 25, 2009 at 8:43 PM, Mark Clements (HappyDog)<gmane(a)kennel17.co.uk> wrote:

I noticed the problem here: http://en.wikipedia.org/wiki/Neil%27s_Heavy_Concept_Album

Now that you mention it, that does look marginally odd. Both options seem pretty reasonable, so unless anyone feels strongly about it, seems like there is no issue? (One slight advantage I see in not linking the "'s" is to slightly reduce the chance of two consecutive linked phrases. [[John]]'s [[bike]] is more clearly two separate links. Steve

Reply

Platonides

28 Jun 28 Jun

12:56 a.m.

Steve Bennett wrote:

On Thu, Jun 25, 2009 at 8:43 PM, Mark Clements (HappyDog)<gmane(a)kennel17.co.uk> wrote:

I noticed the problem here: http://en.wikipedia.org/wiki/Neil%27s_Heavy_Concept_Album

Now that you mention it, that does look marginally odd. Both options seem pretty reasonable, so unless anyone feels strongly about it, seems like there is no issue? (One slight advantage I see in not linking the "'s" is to slightly reduce the chance of two consecutive linked phrases. [[John]]'s [[bike]] is more clearly two separate links. Steve

So keeep it as it's. Currently, people wanting 's linked can do it using [[Foo|Foo's]] while getting the 's outside would require ugliness like [[Foo]]<nowiki></nowiki>'s.

Reply

Mark Clements (HappyDog)

6:44 p.m.

"Platonides" <Platonides(a)gmail.com> wrote in message news:h2685k$3db$2@ger.gmane.org...

Steve Bennett wrote:

On Thu, Jun 25, 2009 at 8:43 PM, Mark Clements (HappyDog)<gmane(a)kennel17.co.uk> wrote:

I noticed the problem here: http://en.wikipedia.org/wiki/Neil%27s_Heavy_Concept_Album

Now that you mention it, that does look marginally odd. Both options seem pretty reasonable, so unless anyone feels strongly about it, seems like there is no issue? (One slight advantage I see in not linking the "'s" is to slightly reduce the chance of two consecutive linked phrases. [[John]]'s [[bike]] is more clearly two separate links. Steve

So keeep it as it's. Currently, people wanting 's linked can do it using [[Foo|Foo's]] while getting the 's outside would require ugliness like [[Foo]]<nowiki></nowiki>'s.

Fair point. - Mark Clements (HappyDog)

Reply

5409

days inactive

5413

days old

wikitech-l@lists.wikimedia.org

Manage subscription

8 comments

5 participants

tags (0)

participants (5)

Aryeh Gregor
Mark Clements (HappyDog)
Petr Kadlec
Platonides
Steve Bennett