Hi!

# TLDR

1.34.0-wmf.20 is at group 0, but blocked https://phabricator.wikimedia.org/T220745

# Blockers

Train will not move forward until the following tasks are resolved or removed from blockers:

* DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code https://phabricator.wikimedia.org/T231029

* TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given https://phabricator.wikimedia.org/T231340

* BadFileLookup.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget or be null, boolean given https://phabricator.wikimedia.org/T231353

* File '/srv/mediawiki/php-1.34.0-wmf.20/skins/MinervaNeue/resources/resources/skins.minerva.personalMenu.icons/userSandbox.svg' does not exist https://phabricator.wikimedia.org/T231358

# Resolved

Following tasks have been resolved:

* ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" https://phabricator.wikimedia.org/T231014

* LegacyHandler.php: PHP Warning: Host lookup failed [-10002]: Unknown error -10002 https://phabricator.wikimedia.org/T231025

* L10n cache is completely broken https://phabricator.wikimedia.org/T231183

I would like to thank everybody that helped resolve train problems, and especially pmiazga (Piotr Miazga), hashar (Antoine Musso) and Simetrical (Aryeh Gregor).

# Removed from blockers

Following task were removed from train blockers:

* /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max https://phabricator.wikimedia.org/T231071

* ApiQueryContentTranslation.php: PHP Notice: Trying to get property 'translation' of non-object https://phabricator.wikimedia.org/T231284

* RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979 https://phabricator.wikimedia.org/T231276

The tasks are still not resolved, so any help is appreciated. I would like to thank for hashar (Antoine Musso) for investigating the issues and removing the tasks from blockers.

# Log spam

Additionally, I've found this errors in logs, but since they are not new, they are not blocking the train.

* Assert.php: Bad value for parameter $responses: must have as many responses as requests https://phabricator.wikimedia.org/T231023 * Assert.php: Bad value for parameter $oldContent: must be a TextContent|null https://phabricator.wikimedia.org/T231084 * WikibaseClient.php: PHP Notice: Undefined index: https://phabricator.wikimedia.org/T231089

# mediawiki-new-errors

I would also like to thank Krinkle (Timo Tijhof) for creating mediawiki-new-errors dashboard. I've found all of the problems using it. The dashboard is far from empty. Feel free to use it to find and report problems.

https://logstash.wikimedia.org/goto/b65b808294695129cef5f26257e1f944

Željko

On Tue, Aug 27, 2019 at 11:42 AM Željko Filipin zfilipin@wikimedia.org wrote:

I would like to thank everybody that worked on resolving train blockers. These tasks are now resolved.

• L10n cache is completely broken

https://phabricator.wikimedia.org/T231183

I've found more problems that are blocking the train from even starting.

• RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146

instead of expected M81625979 https://phabricator.wikimedia.org/T231276

• ApiQueryContentTranslation.php: PHP Notice: Trying to get property

'translation' of non-object https://phabricator.wikimedia.org/T231284

Any help in resolving the tasks is greatly appreciated.

Thank you,

Željko

On Mon, Aug 26, 2019 at 8:07 PM Željko Filipin zfilipin@wikimedia.org wrote:

...

The 1.34.0-wmf.20 version of MediaWiki is blocked.

https://phabricator.wikimedia.org/T220745

The new version is not deployed anywhere yet. It will not be deployed until these issues are resolved:

• ServiceContainer.php: Circular dependency when creating MobileFrontend

service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" https://phabricator.wikimedia.org/T231014

• DefaultPreferencesFactory.php: Global default '' is invalid for field

incubatortestwiki-code https://phabricator.wikimedia.org/T231029

• /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to

unserialize ... Size of serialized string ... exceeds max https://phabricator.wikimedia.org/T231071

• L10n cache is completely broken

https://phabricator.wikimedia.org/T231183

Once these issues are resolved train can start.

Additionally, I've found this errors in logs, but since they are not new, they are not blocking the train.

• Assert.php: Bad value for parameter $responses: must have as many

responses as requests https://phabricator.wikimedia.org/T231023

• Assert.php: Bad value for parameter $oldContent: must be a

TextContent|null https://phabricator.wikimedia.org/T231084

• WikibaseClient.php: PHP Notice: Undefined index:

https://phabricator.wikimedia.org/T231089

Thank you for your help resolving these issues!

-- Your humble train toiler, Željko

Can you give an update on the status of the train? Will Group 2 be moved to wmf.20 or will it skip that version? https://tools.wmflabs.org/versions/

Thanks!

On Thu, Aug 29, 2019 at 12:48 PM Željko Filipin zfilipin@wikimedia.org wrote:

The 1.34.0-wmf.20 version of MediaWiki is blocked[0].

The new version is deployed to groups{0,1}[1], but can proceed no further until these issues are resolved:

• T231542 AFPData.php: Refusing to cast DUNDEFINED to something else

• T231554 ApiQueryMapData.php: Call to a member function getData() on a

non-object (null)

• T231561 ApiQueryMapData.php: Call to a member function getData() on null

Once these issues are resolved train can resume. If these issues are resolved on a Friday the train will resume Monday.

Thank you for your help resolving these issues!

-- Your humble train toiler

[0]. https://phabricator.wikimedia.org/T220745 [1]. https://tools.wmflabs.org/versions/

On Tue, Aug 27, 2019 at 7:42 PM Željko Filipin zfilipin@wikimedia.org wrote:

...

Hi!

# TLDR

1.34.0-wmf.20 is at group 0, but blocked https://phabricator.wikimedia.org/T220745

# Blockers

Train will not move forward until the following tasks are resolved or removed from blockers:

• DefaultPreferencesFactory.php: Global default '' is invalid for field

incubatortestwiki-code https://phabricator.wikimedia.org/T231029

• TraditionalImageGallery.php: Argument 2 passed to

MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given https://phabricator.wikimedia.org/T231340

• BadFileLookup.php: Argument 2 passed to

MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget or be null, boolean given https://phabricator.wikimedia.org/T231353

• File

'/srv/mediawiki/php-1.34.0-wmf.20/skins/MinervaNeue/resources/resources/skins.minerva.personalMenu.icons/userSandbox.svg'

...

does not exist https://phabricator.wikimedia.org/T231358

# Resolved

Following tasks have been resolved:

• ServiceContainer.php: Circular dependency when creating MobileFrontend

service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" https://phabricator.wikimedia.org/T231014

• LegacyHandler.php: PHP Warning: Host lookup failed [-10002]: Unknown

error -10002 https://phabricator.wikimedia.org/T231025

• L10n cache is completely broken

https://phabricator.wikimedia.org/T231183

I would like to thank everybody that helped resolve train problems, and especially pmiazga (Piotr Miazga), hashar (Antoine Musso) and Simetrical (Aryeh Gregor).

# Removed from blockers

Following task were removed from train blockers:

• /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to

unserialize ... Size of serialized string ... exceeds max https://phabricator.wikimedia.org/T231071

• ApiQueryContentTranslation.php: PHP Notice: Trying to get property

'translation' of non-object https://phabricator.wikimedia.org/T231284

• RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146

instead of expected M81625979 https://phabricator.wikimedia.org/T231276

The tasks are still not resolved, so any help is appreciated. I would

like

...

to thank for hashar (Antoine Musso) for investigating the issues and removing the tasks from blockers.

# Log spam

Additionally, I've found this errors in logs, but since they are not new, they are not blocking the train.

• Assert.php: Bad value for parameter $responses: must have as many

responses as requests https://phabricator.wikimedia.org/T231023

• Assert.php: Bad value for parameter $oldContent: must be a

TextContent|null https://phabricator.wikimedia.org/T231084

• WikibaseClient.php: PHP Notice: Undefined index:

https://phabricator.wikimedia.org/T231089

# mediawiki-new-errors

I would also like to thank Krinkle (Timo Tijhof) for creating mediawiki-new-errors dashboard. I've found all of the problems using it. The dashboard is far from empty. Feel free to use it to find and report problems.

https://logstash.wikimedia.org/goto/b65b808294695129cef5f26257e1f944

Željko

On Tue, Aug 27, 2019 at 11:42 AM Željko Filipin zfilipin@wikimedia.org wrote:

...

I would like to thank everybody that worked on resolving train blockers. These tasks are now resolved.

• L10n cache is completely broken

https://phabricator.wikimedia.org/T231183

I've found more problems that are blocking the train from even starting.

• RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146

instead of expected M81625979 https://phabricator.wikimedia.org/T231276

• ApiQueryContentTranslation.php: PHP Notice: Trying to get property

'translation' of non-object https://phabricator.wikimedia.org/T231284

Any help in resolving the tasks is greatly appreciated.

Thank you,

Željko

On Mon, Aug 26, 2019 at 8:07 PM Željko Filipin zfilipin@wikimedia.org wrote:

...

The 1.34.0-wmf.20 version of MediaWiki is blocked.

https://phabricator.wikimedia.org/T220745

The new version is not deployed anywhere yet. It will not be deployed until these issues are resolved:

• ServiceContainer.php: Circular dependency when creating

MobileFrontend

...

...

...

service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" https://phabricator.wikimedia.org/T231014

• DefaultPreferencesFactory.php: Global default '' is invalid for field

incubatortestwiki-code https://phabricator.wikimedia.org/T231029

• /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to

unserialize ... Size of serialized string ... exceeds max https://phabricator.wikimedia.org/T231071

• L10n cache is completely broken

https://phabricator.wikimedia.org/T231183

Once these issues are resolved train can start.

Additionally, I've found this errors in logs, but since they are not new, they are not blocking the train.

• Assert.php: Bad value for parameter $responses: must have as many

responses as requests https://phabricator.wikimedia.org/T231023

• Assert.php: Bad value for parameter $oldContent: must be a

TextContent|null https://phabricator.wikimedia.org/T231084

• WikibaseClient.php: PHP Notice: Undefined index:

https://phabricator.wikimedia.org/T231089

Thank you for your help resolving these issues!

-- Your humble train toiler, Željko

---

Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l