On 20/08/07, Magnus Manske <magnusmanske(a)googlemail.com> wrote: Hmm, I was just poking MediaFunctions, considering doing this, and I have to admit, while it seems more "natural" to have the target first, being able to omit the image name on an image page does seem convenient...hadn't thought of that. This seems sensible, although I'd ditch the underscore and define some magic words for the individual EXIF bits. We might or might not want to provide some accessor for raw data with absolute named values, for the Gregs. ;) Rob Church

On 20/08/07, Tim Starling <tstarling(a)wikimedia.org> wrote: I don't understand whether you're objecting to the function name, which is trivial to change, or how the function actually operates...? Rob Church

Magnus Manske wrote: Just the function name. It's not really that easy to change once it's in use on the wiki, it's easier if we get it right from the outset. The media handlers are in the includes/media directory. The new Ogg handler is in extensions/OggHandler. Presumably we would have a metadata accessor in the File object, which passes through to the media handler. The interface for metadata is not yet finalised, so I wouldn't actually recommend making this work for arbitrary media types just yet. If I were you, I would stick with: $metadata = $file->getMetadata(); $handler = $file->getHandler(); $metadataType = $handler ? $handler->getMetadataType( $file ) : false; if ( $metadataType != 'exif' ) return 'Media type not supported'; That gives you forwards-compatibility. You can leave the abstraction until I've finished with the media handler work. -- Tim Starling