Do you think we could at least use some sort of $wgUseUnicodeLinktrail and default it to false until we find a good way to test if it is supported?
~Daniel Friesen(Dantman, Nadir-Seen-Fire) of: -The Nadir-Point Group (http://nadir-point.com) --It's Wiki-Tools subgroup (http://wiki-tools.com) --The ElectronicMe project (http://electronic-me.org) --Games-G.P.S. (http://ggps.org) -And Wikia ACG on Wikia.com (http://wikia.com/wiki/Wikia_ACG) --Animepedia (http://anime.wikia.com) --Narutopedia (http://naruto.wikia.com)
tstarling@svn.wikimedia.org wrote:
Revision: 38751 Author: tstarling Date: 2008-08-07 04:32:46 +0000 (Thu, 07 Aug 2008)
Log Message:
(Bug 15035) Revert linkTrail to /^([a-z]+)(.*)$/sD, as it was before r36253. Multiple reports of breakage due to old (pre-5.0) PCRE libraries, both bundled with PHP and packaged with distros such as RHEL.
Modified Paths:
trunk/phase3/languages/messages/MessagesEn.phpModified: trunk/phase3/languages/messages/MessagesEn.php
--- trunk/phase3/languages/messages/MessagesEn.php 2008-08-07 04:25:55 UTC (rev 38750) +++ trunk/phase3/languages/messages/MessagesEn.php 2008-08-07 04:32:46 UTC (rev 38751) @@ -443,7 +443,7 @@
- Regular expression matching the "link trail", e.g. "ed" in [[Toast]]ed, as
- the first group, and the remainder of the string as the second group.
*/ -$linkTrail = '/^(\p{L&}+)(.*)$/usD'; +$linkTrail = '/^([a-z]+)(.*)$/sD';
/**
- List of filenames for some ui images that can be overridden per language
Amendum, this would probably fit in similar to $wgCookieHttpOnly as something like $wg[Support[s|ed]|Use]PcreUnicodeProp[ertie]s and may actually have more use than just the linktrail.
~Daniel Friesen(Dantman, Nadir-Seen-Fire) of: -The Nadir-Point Group (http://nadir-point.com) --It's Wiki-Tools subgroup (http://wiki-tools.com) --The ElectronicMe project (http://electronic-me.org) --Games-G.P.S. (http://ggps.org) -And Wikia ACG on Wikia.com (http://wikia.com/wiki/Wikia_ACG) --Animepedia (http://anime.wikia.com) --Narutopedia (http://naruto.wikia.com)
Daniel Friesen wrote:
Do you think we could at least use some sort of $wgUseUnicodeLinktrail and default it to false until we find a good way to test if it is supported?
~Daniel Friesen(Dantman, Nadir-Seen-Fire) of: -The Nadir-Point Group (http://nadir-point.com) --It's Wiki-Tools subgroup (http://wiki-tools.com) --The ElectronicMe project (http://electronic-me.org) --Games-G.P.S. (http://ggps.org) -And Wikia ACG on Wikia.com (http://wikia.com/wiki/Wikia_ACG) --Animepedia (http://anime.wikia.com) --Narutopedia (http://naruto.wikia.com)
tstarling@svn.wikimedia.org wrote:
Revision: 38751 Author: tstarling Date: 2008-08-07 04:32:46 +0000 (Thu, 07 Aug 2008)
Log Message:
(Bug 15035) Revert linkTrail to /^([a-z]+)(.*)$/sD, as it was before r36253. Multiple reports of breakage due to old (pre-5.0) PCRE libraries, both bundled with PHP and packaged with distros such as RHEL.
Modified Paths:
trunk/phase3/languages/messages/MessagesEn.phpModified: trunk/phase3/languages/messages/MessagesEn.php
--- trunk/phase3/languages/messages/MessagesEn.php 2008-08-07 04:25:55 UTC (rev 38750) +++ trunk/phase3/languages/messages/MessagesEn.php 2008-08-07 04:32:46 UTC (rev 38751) @@ -443,7 +443,7 @@
- Regular expression matching the "link trail", e.g. "ed" in [[Toast]]ed, as
- the first group, and the remainder of the string as the second group.
*/ -$linkTrail = '/^(\p{L&}+)(.*)$/usD'; +$linkTrail = '/^([a-z]+)(.*)$/sD';
/**
- List of filenames for some ui images that can be overridden per language
Daniel Friesen wrote:
tstarling@svn.wikimedia.org wrote:
[...]
-$linkTrail = '/^(\p{L&}+)(.*)$/usD'; +$linkTrail = '/^([a-z]+)(.*)$/sD';
/**
- List of filenames for some ui images that can be overridden per language
Do you think we could at least use some sort of $wgUseUnicodeLinktrail and default it to false until we find a good way to test if it is supported?
Amendum, this would probably fit in similar to $wgCookieHttpOnly as something like $wg[Support[s|ed]|Use]PcreUnicodeProp[ertie]s and may actually have more use than just the linktrail.
Well, if you want a feature test, you can just use
defined('PCRE_VERSION') && version_compare(PCRE_VERSION, '5.0', '>=')
But I couldn't see the point. It's not like it was a frequently-requested feature. I'd rather keep the syntax consistent across all installations.
-- Tim Starling
wikitech-l@lists.wikimedia.org