Yuri Astrakhan wrote:
Brion, the code was copied from the OutputPage.php
line 751:
if ( is_numeric( $id ) ) {
$name = User::whoIs( $id );
} else {
$name = $id;
}
Guess it should be fixed there as well.
Probably, yes.
Note that almost *every* time you see is_numeric() it's probably wrong.
Usually people seem to use it when what they *mean* is
preg_match('/^\d+$/'), but it also matches things with decimals, hex, etc.
return is_numeric('234.444');
bool(true)
return is_numeric(' 234');
bool(true)
return is_numeric('0x7f');
bool(true)
-- brion vibber (brion @
wikimedia.org)