Hi Alex!
Thanks for your e-mail and for bringing this up to the list :) This actually seems to be a
bug to me, as the key should be skins (as stated in the schema as well as in the function
doc block), however, it is named "skin", which is false. As such, I would bring
in another option (apart from what you already suggested): Fix it :) As a bug, and as the
schema is actually correct, all extensions using the depend on skins functionality of
extension registration will either fail to use the extension.json as an exception is
thrown during processing the registration file, or otherwise will fail the validation
(validateRegistrationFile.php),[1] which should be the base check for each extension
developer to see if the extension matches standard.
My suggestion is:
* Open a bug for it (see ->
https://phabricator.wikimedia.org/T197478)
* Fix the bug in master
* Backport the fix to the supported releases and let the fix roll out with the next minor
release (if the release manager agrees)
Is that ok for you, too? :)
Best,
Florian
-----Ursprüngliche Nachricht-----
Von: Wikitech-l <wikitech-l-bounces(a)lists.wikimedia.org> Im Auftrag von Alex
Winkler
Gesendet: Freitag, 15. Juni 2018 16:42
An: wikitech-l(a)lists.wikimedia.org
Betreff: [Wikitech-l] Extension registration dependencies towards skins
Hello together,
I'm currently working on upgrading some wikis to Mediawiki 1.31, and I've been
reading the manual on extension dependencies. It is clearly stated at
https://www.mediawiki.org/wiki/Manual:Extension_registration#Requirements_(…
that skins can be required with the key "skins", however looking at git and the
change in gerrit, the key is actually implemented as "skin"
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/250060/33/includes/regi….
The change in itself is inconsistent, as it adds both documentation and actual code which
are not compatible to each other.
I've been wondering if it is just the documentation being wrong or the key being
typo'd ever since 1.29, considering the extensions dependency key is inplural I'd
tend to think the key is typo'd ever since 1.29.
Question would then be how to resolve this. The best way would probably be to deprecate
the "skin" key and implement "skins" as a key, and remove
"skin" with the next major release (1.32), as I don't think the actual
behaviour should be changed mid-release.
--
Alex "FO-nTTaX" Winkler
Head of Liquipedia Development
https://liquipedia.net/ -
https://www.teamliquid.com/
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l