On 21/05/2019 23:40, Amir Sarabadani wrote:
Hey, You probably know about the tag, it has been added automatically to phabricator tickets when someone makes a patch to gerrit and mentions the pabricator ticket (For example [0]). The problem is when the patch gets merged the tag doesn't get removed automatically because there might be other outstanding patches, etc.
Now, lots of time of our developers is being spent on removing those tags when they don't apply which is tedious and with lots of tasks incorrectly having the tag, the tag itself is useless. So I wrote a bot to clean those tags.
In order to make sure I don't remove anything by mistake, the bot doesn't touch the ticket if any of these conditions apply:
- If the tag is added by someone else than the gerrit bot
- If there's a link to github.com anywhere
- If there are still patches that are not merged (ta-duh)
- If gerritbot in any way acts out of ordinary (for example, comments twice
for adding one patch)
It's going to spam your inbox. Sorry:( I'm working on it to find a less spammy way and will definitely run it with slow pace.
Hello,
I appreciate your initiative to cleanup Phabricator but in this case I do not see a point of removing #patch-for-review on tasks that are marked as resolved and are months, if not years old.
Can you please stop this bot because it is flooding my email inbox. Or at least exclude tasks marked as resolved!
Thank you!