Hi folks,
To help accelerate code review, we (WMF) have recently made efforts to
expand the +2 merge right on Git/Gerrit, consistent with the idea that
+2 is an expression of trust and confidence in someone's judgment
rather than an indicator of universal technical competence.
For example, you might have +2 on core, but specialize in front-end
code, or documentation fixes, or test changes. That means you would be
expected to only merge changes relevant to those areas, and we trust
you to exercise good judgment to do so.
Our intent is therefore to grant +2 more broadly than we have in the
past, but to also establish clear parameters under which we would
revoke it.
So we've:
- expanded +2 to all full-time WMF engineers by adding them to a 'wmf'
group which has +2 rights on the following repos: apps, glam,
integration, mediawiki, qa, search, translatewiki,
webplatform.org
- been more open in handing out +2 to MediaWiki core. Sumana has been
actively nominating trusted volunteers to ensure that they get merge
rights. Five volunteers have gained maintainership rights in the past
week, and we're encouraging you to apply:
https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership
- posted a draft policy for owners of the +2 permission here:
https://www.mediawiki.org/wiki/%2B2
This last bit is the critical part -- as we expand +2, these are the
terms under which reviewers would be expected to operate. Please leave
comments on the talk page if anything strikes you as onerous or
unreasonable, or missing.
Hopefully this will reduce friction introduced with the Git/Gerrit
permissions model and review-related blockers.
All best,
Erik
--
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation
Support Free Knowledge:
https://wikimediafoundation.org/wiki/Donate