On 09/04/2012 05:31 PM, Mark A. Hershberger wrote:
On 09/04/2012 07:38 PM, MZMcBride wrote:
I think some
kind of reconciliation is needed here in the advice to
committers, new and old. I guess whether to split commits up or not depends
Or maybe these simply the differences in the sorts of reviews that
people like to do? Or maybe its a bit of both?
"If this is a major change you really want Tim to review, then make a
single big commit. If you want Krinkle to review your code, don't batch
it up into several seemingly unrelated changes in a big blob."
Because Sumana's initial instructions weren't about any particular
developer, maybe this is just something she has noticed as a tendency?
That particular suggestion -- writing small commits -- came from Daniel
Kinzler, who gave feedback on the draft (see 19:55:45 in
believe I have also heard similar advice from others.
I would love more clarifications from developers to help people decide
when to lump commits together into a changeset and when to split things up.
Engineering Community Manager