2009/5/16 Freako F. Freakolowsky <freak(a)drajv.si>si>:
Why was this approach opposed?
I am working on Oracle abstraction at the moment and i was planning to
implement such a function.
DJ Bauch wrote:
I would much rather see a function added at the
Database
class level to form compound queries from subqueries, since the
alternative is to introduce conditional code at the special page level
that is selected on the basis of the SQL syntax of the database engine
-- and that approach has been justifiably opposed by Brion and others
in the past. I would then override that function in my derived
DatabaseADODB class, as I already am doing with several other
functions.
What I think DJ Bauch meant was that conditional code in special
pages
deciding which SQL to use based on $wgDBtype is a bad idea and has
been opposed. Adding a function to the Database class to form compound
queries has, to my knowledge, not been opposed.
Roan Kattouw (Catrope)