On Sun, Nov 14, 2010 at 7:04 PM, Platonides <Platonides(a)gmail.com> wrote:
You are changing the tools but not the problem.
Jack wants his extension reviewed. Nobody seem to care about it. Naming
it 'without wmf-deployment flag' instead of 'marked as deferred'
won't help.
Agreed.
And deferred doesn't mean that nobody cares like people keep saying. It
means that the code reviewer in question doesn't care /right now/. This
happens for one of the following reasons
1) i18n commits: we almost never review these in full because they're huge
and it's a very tested process (exporting and checking in the changes)
2) It's a non-WMF extension or other piece of code (eg: WikiWord)
3) Your own code from quite some time ago, and nobody has bothered
reviewing it (the newer 'old' status might be better for this, however)
Deferred isn't a graveyard, anything can be pulled out of it for review. FWIW,
I just marked all the SocialProfile deferred commits back to new since he
wants it reviewed.
Generally speaking, I review the following (in no particular order, and (b)
overlaps with (a) and (c) sometimes)
a) Core changes
b) Things I am interested in
c) WMF extensions I work on, eg: FlaggedRevs & CodeReview
Most extensions don't fall into this category for me, so I don't bother looking
at them. I'm perfectly willing to leave SocialProfile as new if someone indeed
will take up review of it. My main issue is leaving things "new" forever that
nobody actually reviews.
-Chad