On 09/07/07, Andrew Garrett andrew@epstone.net wrote:
This is half of the work I've done so far.. My changes currently affect about 40-odd files.
Just a quick note; if you're adding any cleverness to the parser (section edit links, etc.), don't forget to maintain cache coherency.
Probably just paranoia, but it's caught me out before, so...
I don't know. I spoke to Tim about it, so I expect it's sane. However, it's still subject to the opinions of other developers, including Brion. The change has not yet been applied.
My gut says it might be saner to return a simple array( const, message ), where const is one of a set of constants defined somewhere, perhaps abusing a class for namespace purposes, which provides a simple meaningful check. You might as well render the message *for* the caller, since you're basically passing back all the pieces.
Rob Church