FlaggedRevs uses the NewRevisionFromEditComplete hook. Grepping for that, I
see reasonable values set in the callers at a quick glance. This cover
various null edit scenarios too. The $baseRevId in WikiPage is just one of
the cases of that value passed to the hook, and is fine there (being mostly
false). "false" indeed means "not determined" and that behavior is
needed
for the hook values. The values given in that hook variable make sense and
are more or less consistent.
As I said before, if the NewRevisionFromEditComplete hook is given the same
base revision ID values for all cases, then I don't care to much what
happens to the $baseRevId value semantics in doEditContent(). As long as
everything is changed to keep that part consistent then it won't effect
anything. However, just naively change the $baseRevId values for the
non-false cases will break the extension using it.
As as side note, FlaggedRevs doesn't just end up using $oldid. It only uses
that as the last resort after picking other values in difference scenarios
it detects.
--
View this message in context:
http://wikimedia.7.x6.nabble.com/Unclear-Meaning-of-baseRevId-in-WikiPage-d…
Sent from the Wikipedia Developers mailing list archive at
Nabble.com.