-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tim Starling wrote:
Erik Moeller wrote:
On 8/30/07, brion(a)svn.wikimedia.org
<brion(a)svn.wikimedia.org> wrote:
Adds what seems to be a very purpose-specific
extension into the core API:
It's not that purpose-specific.. the name in the code should perhaps
be changed. The purpose is to be able to declare a site as a remote
repository and have it work in the same way Commons does in the WMF
environment.
That's all very well, but it will be rather useless until there is also
a client side. All the instantcommons API module does at the moment is
dumps all the string properties of an Image object loaded by name.
Which should already be present in the API, so why add a second one?
What really confused me was the example URLs it lists which do things
like 'delete' and 'update' .... this doesn't seem to make any clear
sense in either a server or client-side API, and they're not implemented
either, so they *definitely* don't belong on trunk.
Remember that trunk is supposed to be *live code* -- keeping things up
to date and ready to run at all times is our biggest method of quality
control. Code *must work* at all times, expect of course when it's
broken by accident. :)
At the minimum there needs to be a way for servers to
specify whether or
not they give their consent for their image repository to be used as a
remote repository in a foreign MediaWiki installation. A generic image
properties API would be fine in the core (if it was properly
implemented), but the InstantCommons client most certainly couldn't use
it without this permissions element.
I've moved it to an extension, it's at extensions/InstantCommons.
Thanks.
- -- brion vibber (brion @
wikimedia.org)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla -
http://enigmail.mozdev.org
iD8DBQFG2Gt5wRnhpk1wk44RAoxqAJ9YFBncpLXbw4KnuAmEkCom0uvVrACgqmWe
w2bHDeVqZgssJbOixXOWDM4=
=NDqW
-----END PGP SIGNATURE-----