On Fri, May 1, 2009 at 4:32 PM, Ilmari Karonen nospam@vyznev.net wrote:
Not sure if it's worth the trouble, at least unless someone can think of a good place to put the check such that we don't have to run it on each and every request. Sure, the cost of such a check is minimal, but so is the frequency with which most people change their $wgUploadPath.
If avoiding a single preg_match() would make a noticeable difference in the speed of our code, I'd be *very* happy. :) We already run plenty of trivial sanity checks on every page view. One more is not going to hurt anything.