On Tue, 04 Dec 2012 12:37:02 -0800, Chad
<innocentkiller(a)gmail.com> wrote:
On Tue, Dec 4, 2012 at 3:27 PM, Chad
<innocentkiller(a)gmail.com> wrote:
On Tue, Dec 4, 2012 at 3:24 PM, Tyler Romeo
<tylerromeo(a)gmail.com> wrote:
> Don't we have some sort of policy about an individual merging commits that
> he/she uploaded?
>
Yes. We've been over this a dozen times--if you're on a repository
that has multiple maintainers (ie: you're not the only one, so you're
always self-merging), you should almost never merge your own
code unless you're fixing an immediate problem (site outage, sytax
errors).
In fact, I'm tired of repeating this problem, so I started a change to
actually enforce this policy[0]. We'll probably need to tweak it further
to allow for the exceptions we actually want. Review welcome.
-Chad
[0]
https://gerrit.wikimedia.org/r/#/c/36815/
Doesn't TWN's bot self-review? Might need to add an exception for that before
merging.