This is also the approach we have just taken on the Wikibase codebase.
It worked very well!
On 25 September 2015 at 22:45, Tyler Romeo <tylerromeo(a)gmail.com> wrote:
On Fri, Sep 25, 2015 at 2:08 PM, Legoktm
<legoktm.wikipedia(a)gmail.com>
wrote:
I've tried out a different approach in
<https://gerrit.wikimedia.org/r/#/c/241085/>, by disabling all the
failing rules. This will let us make the rules that do pass voting (e.g.
no closing ?> tags), and we can selectively enable failing rules instead
of trying to make giant patches and hope no one introduces regressions
while it's still non-voting.
Very much agree with this post. I have worked on phpcs compliance on other
projects at my company, and we have found it vastly easier to stage-in over
time, that way at the very least additional errors are not accidentally
introduced.
*-- *
*Tyler Romeo*
Stevens Institute of Technology, Class of 2016
Major in Computer Science
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l