Hello all,
I submitted a patch for bug 3270 in bugzilla, also included below. What
I changed is that now the rc bots will add the rcid variable to the http
query, but only if the global variable $wgUseRCPatrol is set, which I
believe is only the case in Dutch wikipedia.
This fix is very important for vandal fighting on nl.wp, because it will
enable VandalFighter to mark edits as patrolled, so they aren't checked
again manually at a later time (which happens now).
The patch has been tested. The revision of RecentChange.php I patched
against is 1.37, which is the current revision as of this e-mail.
I hope this patch can be committed soon; it will make many Dutch users
very happy!
Regards,
Leon Planken (aka Oliphaunt)
Patch follows:
--- /home/people/oliphaunt/wiki/RecentChange.php 2005-10-28 14:01:30.000000000 +0200
+++ RecentChange.php 2005-10-28 14:30:11.000000000 +0200
@@ -125,6 +125,9 @@
# Insert new row
$dbw->insert( 'recentchanges', $this->mAttribs, $fname );
+ # Retrieve the id assigned by MySQL
+ $this->mAttribs['rc_id'] = $dbw->insertId();
+
# Update old rows, if necessary
if ( $this->mAttribs['rc_type'] == RC_EDIT ) {
$oldid = $this->mAttribs['rc_last_oldid'];
@@ -422,6 +425,8 @@
}
function getIRCLine() {
+ global $wgUseRCPatrol;
+
extract($this->mAttribs);
extract($this->mExtra);
@@ -434,6 +439,8 @@
if ( $rc_new ) {
$url = $titleObj->getFullURL();
+ } else if ( $wgUseRCPatrol ) {
+ $url =
$titleObj->getFullURL("diff=0&oldid=$rc_last_oldid&rcid=$rc_id");
} else {
$url = $titleObj->getFullURL("diff=0&oldid=$rc_last_oldid");
}
--
I really didn't foresee the Internet. But then, neither did
the computer industry. Not that that tells us very much, of
course - the computer industry didn't even foresee that the
century was going to end. -- Douglas Adams (1952 - 2001)