I personally reserve -2 for "this is a fundamentally bad idea" or "this
requires
community consensus before being implemented". Anything that is fixable in the
code should get a -1 or 0.
Btw, I personally prefer to get -1 reviews over 0 reviews, simply because it's
easier to spot them as "todo" on the gerrit dashboard. If gerrit would
highlight
"stuff with new comments" more prominently, I'd probably use 0 more often.
Am 05.04.2016 um 16:18 schrieb Jon Robson:
I think a review is valuable no matter what the
score... with the
possible exception of -2 which I fear is probably a bit too aggressive
and unnecessary in our ecosystem for which reason the reading web team
agreed to avoid the use of -2 except to stop merges in progress that
were not ready. I review with score 0 quite a lot for instance.
On Tue, Apr 5, 2016 at 3:59 PM, Federico Leva (Nemo) <nemowiki(a)gmail.com> wrote:
I, for
example, value better good -1 code reviews
Same here. There are statistics for -1 too, two clicks away from the link I
provided in the previous message.
https://www.mediawiki.org/wiki/Gerrit/Reports/Code_review_activity
Nemo
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l