On Thu, Jul 10, 2008 at 4:34 PM, Platonides Platonides@gmail.com wrote:
Simetrical wrote:
However, we don't *really* have to use the same name in the filesystem as we use as a title. This seems to me like it would be better implemented by mangling the filename somehow. The invalid Windows/DOS characters are supposedly:
? [ ] / \ = + < > : ; " ,
[]=+;, are legal on windows.
Of those, I think the following are currently legal in image names (before your commit):
? \ = + : ; " ,
(Googled sources actually conflict as to the exact list of prohibited characters. Some say * is prohibited, some don't mention it.
It is for being a wildcard.
Same for |.
It is for being the pipe character.
Regardless of it being allowed or not, it sound like a bad idea to me to allow ?*| in filenames.
and there are other restrictions, like no trailing space or period,
hmm, right. Although not really applicable for images which will have an extension appended.
But it still is something which wfStripIllegalFilenameChars should catch.
and a list of reserved names like "com1" and "nul".
Strangely, not only are com1 and nul prohibited, but also nul.png or com1.jpg
Uh... ok... so basically MediaWiki installations having com1.png files are not platform compatible?