Netocrat wrote:
On Tue, 29 Nov 2005 00:09:04 +1100, Netocrat wrote:
I noticed while validating the HTML output of an extension that some urls are being generated with a plain & instead of encoded as & and the W3C validator complains about this as an error. This patch fixes the line of code that was the source of the uncoded ampersand (and another line I noticed) if anyone with CVS access chooses to apply it.
Looks like the attachment's been stripped on gmane. Here it is inline.
[snip]
$url = "{$wgScript}?title={$dbkey}&{$query}";
$url = "{$wgScript}?title={$dbkey}&{$query}";
This patch is incorrect, and will cause broken URLs to be output throughout the wiki.
Instead, you should locate the individual *output* of the bad URL that you found and patch *that* to properly HTML-encode its output.
-- brion vibber (brion @ pobox.com)