On Thu, Jul 17, 2008 at 5:40 AM, Brion Vibber brion@wikimedia.org wrote:
demon@svn.wikimedia.org wrote:
Log Message:
Add $wgDefaultDirectoryChmod, allows customizing the default chmod value. Set to 0777 by default to keep current behavior.
Handy... I think there's some other uses of mkdir() directly which should presumably have this default setting applied to them as well...
I'm not super fond of the name though -- maybe $wgDirectoryMode ? :) Anyway...
Compare also with the patch on this old bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=6295
and further notes on: https://bugzilla.wikimedia.org/show_bug.cgi?id=14593
We've got similar issues where we may need to be able to override the default permission mode for thumbnail files, see: https://bugzilla.wikimedia.org/show_bug.cgi?id=6654
Check also texvc, see if old issues there have changed: https://bugzilla.wikimedia.org/show_bug.cgi?id=6248
-- brion
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
The patch on bug 6295 is largely obsolete, as wfImageDir() and friends are no longer in the code. I've closed it as FIXED.
I didn't change any of the hard-coded chmod values (even the 0777's) yet because of things like bug 6654 where an explicit permission is required. At the same time, I don't think churning out a million new config variables for each different permission level we want is the right course of action. I can see all of the 0777's being changed to the new variable, but I think leaving the hard-coded ones as-is for now would be best.
-Chad