On mer, 2002-05-01 at 17:07, Lee Daniel Crocker wrote:
The attached context diff contains fixes for the source file wikiPage.php, with these changes:
Great! But the attachment seems to have fallen out...
- Now accepts "JPG", "PNG", etc., in uppercase as image names. No longer accepts "tif" or "tiff"--that's not an appropriate format for web images, so they'll just be rendered as links.
Sounds good to me.
- Removes HTML comments from wiki text before rendering, so they can be used to leave comments _about_ the wiki text.
Not entirely unreasonable, but has this been discussed on wikipedia-l and/or the wiki?
- Major reworking of the code that handles p/pre/ol/ul/dl. Old code basically ripped out and replaced; now produces clean HTML, compact dls, handles nesting better, etc. I've tested this pretty extensively on my own server without problems, but it is a major change, so you might want to schedule installation for a time when Jimbo or Jason is available to roll it back if I missed something.
Sounds wonderful!
Is there a tool that will reformat PHP code the way "indent" does for C code? This code is a real mess in places.
"indent" might work all right on PHP; but then again it may not, I haven't tried it. I don't know of a specific tool.
-- brion vibber (brion @ pobox.com)