On 15/07/11 14:56, Chad wrote:
<snip>
For more on the "weird API breakage," see
r91215 for an incomplete fix
that shuts up the error (but as Bryan points out isn't strictly correct).
That one would need to be merged so :-)
The block tests are all running fine in trunk, so we
probably need to
backport the rest of the block cleanup or back it out of REL1_18 entirely.
I'm leaning towards the latter as I write this.
The whole block rewrite should probably have been done in a branch.
Would have made things easier. If it is stable enough in trunk we might
as well backport it. If it requires too much work, back it off and
release it with 1.19.
The LST failures need to be tracked down and possibly
backported if
necessary.
I am pretty sure I have fixed them myself. IIRC, the LST tests are
broken following a change in the way <h2> are rendered. The backport
should be easy.
Thanks Chad for the review!
--
Ashar Voultoiz