On Wed, 2004-01-12 at 13:24 +1100, Tim Starling wrote:
I guess
I'm mainly worried that this huge change was made without
considering other options.
What huge change?
Replacing all the SQL strings in the code with function calls into a
much-expanded database object.
As far as I'm concerned, DB abstraction is a
courtesy to low-traffic
non-Wikimedia users.
I'm not speaking as a non-Wikimedia user; I'm speaking as a member of
the MediaWiki development team we're both on.
I'm just trying to get across the point that even the World's Greatest
Programmer can benefit from soliciting the ideas of others in a forum
such as wikitech-l. It only takes a few minutes, helps the developer
focus their own thoughts, and could avoid a lot of work for the entire
development team writing, testing and debugging functionality readily
available in an Open Source library. We all benefit from a better
product that comes from sharing our ideas.
And if you fix your ideas in writing, you don't get dumb questions
later. Or, y'know, fewer dumb questions.
Anyways: sorry if I touched a nerve. If it helps, I think this is a real
nice piece of code, and it really cleans up the rest of the codebase.
~ESP
--
Evan Prodromou <evan(a)wikitravel.org>