Oh and while I'm at it is there any reason why line 161 of \includes\SearchEngine.php cannot be updated to :
return "\x22A-Za-z_'0-9\x80-\xFF\-";
This allows for quoted searches to be passed into the MySQL query engine. Or am I introducing a security hole?
Alex
On Fri, Aug 22, 2008 at 4:18 PM, Alex Powell alexp@exscien.com wrote:
Hi,
Every release of MW since 1.10 I've been making a tweak to the rebuildtextindex.php to replace line 60 with the following code:
if($s->page_namespace != NS_MAIN) { global $wgContLang; $title = $wgContLang->getNsText( $s->page_namespace ) .':' . $s->page_title; } else { $title = $s->page_title; } $u = new SearchUpdate( $s->page_id, $title, $revtext );
I have no idea how the best way to get this into the main code base is, but I'm pretty sure as it stands its wrong in everyone's eyes - since the namespace information is currently lost. Ideally SearchUpdate would be refactored to take a namespace parameter, but this at least allows it to be retrieved intact. I found this problem when adding an extension to index the other namespaces. Or should I be using something else to rebuild the text search?
Kind regards,
Alex
-- Alex Powell
Exscien Training Ltd Tel: +44 (0) 1865 876562 Mob: +44 (0) 7717 765210
skype: alexp700 mailto:alexp@exscien.com http://www.exscien.com
Registered in England and Wales 05927635, Unit 10 Wheatley Business Centre, Old London Road, Wheatley, OX33 1XW, England