K. Peachey wrote:>
One of the major sticking points (that from my
understanding is what
the WMF people are hateing on) is the diff views in comparison of CR
to Gerrit, For example we used to have them all display on one page
where as with Gerrit you need to open each one (each changed file) in
a separate tab, I don't really call that a minor issue.
I like Gerrit diff system. Yeah I know that sounds like trolling read
below though before discarding this mail.
Whenever you click the [Diff All Unified] in Gerrit, a whole bunch of
windows open. Here how to use that:
- pick a window, review code, comment it.
- have you finished that window ?
-> yes : close it
-> no : cycle to next window
Since comments can be saved individually, you can safely close a window
without losing them.
Another advantage is that you can put the files side by side which helps
Previously, we had to move all back to the bottom to add a comment then
go up again. Same applied when reviewing changes in several files. Up
and down constantly. Sometime I ended up doing a svn diff -c 1234 on
each file I was interested in.
When you have patchsets accumulating, you can review the whole bunch of
them since the diff of the lastest patch include all previous patchsets
already. That is a huge advantage over reviewing a bunch of follow up
in our svn world.
If you really want to check what patchset 32 changed, just ask Gerrit to
do the diff based on patchset 31. There is a selector for that.
We can ignore whitespaces from the web interface! One of the alias I
constantly use is:
svn diff -c <revision> -x -wbu
Which does a diff of revision <revision> ignoring white space.
So yes. Gerrit diff is a bit strange but I am sure people will get used
Antoine "hashar" Musso